Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xharness] Fix compiler warning. #9147

Merged
merged 1 commit into from
Jul 22, 2020
Merged

[xharness] Fix compiler warning. #9147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/xharness/Microsoft.DotNet.XHarness.iOS.Shared/XmlResultParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ static TrxTests ParseTrxXml (XmlReader reader)
{
var rv = new TrxTests ();
var tests = new Dictionary<string, TrxTest> ();
TrxTest lastTest = null;
TrxTest? lastTest = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about what compiler warning is generated for the original null assignment 🤔 ❓

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the warning:

warning CS8600: Converting null literal or possible null value to non-nullable type.

It's because this file has enabled nullability.

while (reader.Read ()) {
if (reader.NodeType != XmlNodeType.Element)
continue;
Expand Down