Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a CODEOWNERS file. #2700

Merged
merged 2 commits into from
Sep 15, 2017
Merged

Add a CODEOWNERS file. #2700

merged 2 commits into from
Sep 15, 2017

Conversation

rolfbjarne
Copy link
Member

No description provided.

@rolfbjarne
Copy link
Member Author

This comes from https://github.com/xamarin/maccore/wiki/BUGZ#who-to-ask-about-what-, please check if I've put you in the right place (and not missing anything obvious).

@VincentDondain
Copy link
Contributor

Add me to UIKit I did most for the bindings for xcode9.

Also maybe you should have done that in xcode9 (new Frameworks), I'm ARKit for instance (:

@VincentDondain
Copy link
Contributor

Also please update the wiki once this is merged to link to this file (and remove what's in the wiki so it's no out of sync) (:

@VincentDondain
Copy link
Contributor

Maybe we can just add the new frameworks here already no?

VincentDondain
VincentDondain approved these changes Sep 14, 2017
View reviewed changes
Copy link
Contributor

@VincentDondain VincentDondain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed my own feedback (:

dalexsoto
dalexsoto approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@monojenkins
Copy link
Collaborator

Build failure

spouliot
spouliot reviewed Sep 14, 2017
View reviewed changes
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the wiki version and just add a link to this file (and avoid sync'ing)

@rolfbjarne
Copy link
Member Author

Test failure is unrelated (random introspection/Mac crash due to bug #46115).

@rolfbjarne rolfbjarne merged commit 526d658 into xamarin:master Sep 15, 2017
@rolfbjarne
Copy link
Member Author

The wiki has been updated to point to the CODEOWNERS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot left review comments

@VincentDondain VincentDondain VincentDondain approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

@timrisi timrisi Awaiting requested review from timrisi

@mandel-macaque mandel-macaque Awaiting requested review from mandel-macaque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rolfbjarne @VincentDondain @monojenkins @dalexsoto @spouliot @dnfclas