[msbuild][mac] Fix references netstandard libs from XM/Full #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfbjarne
approved these changes
Sep 12, 2017
This is to handle the case of XM/Full project referencing a netstandard project. For XM/Full, $(TargetFrameworkDirectory) is `lib/mono/4.5` which has `netstandard.dll`. This causes ImplicitlyExpandNETStandardFacades to skip expanding assuming that when ImplicitlyExpandDesignTimeFacades expands facades, `netstandard.dll` would also get referenced. But if the XM project does NOT have any System.Runtime facades, then ImplicitlyExpandDesignTimeFacades will not expand the facades and so we end up with no `netstandard.dll` reference! With `$(NETStandardInbox) == false`, `ImplicitlyExpandNETStandardFacades` behaves as if `netstandard.dll` was not available in the framework directories and will expand the facades if required. Partially fixes bxc #58504 .
radical
force-pushed
the
xm-fix-ns-full-master
branch
from
a9074cf to
0db75e8
Compare
|
Build failure |
|
Build success |
chamons
approved these changes
Sep 12, 2017
emaf
approved these changes
Sep 12, 2017
jstedfast
approved these changes
Sep 12, 2017
chamons
pushed a commit
to chamons/xamarin-macios
that referenced
this pull request
Sep 13, 2017
…2656) This is to handle the case of XM/Full project referencing a netstandard project. For XM/Full, $(TargetFrameworkDirectory) is `lib/mono/4.5` which has `netstandard.dll`. This causes ImplicitlyExpandNETStandardFacades to skip expanding assuming that when ImplicitlyExpandDesignTimeFacades expands facades, `netstandard.dll` would also get referenced. But if the XM project does NOT have any System.Runtime facades, then ImplicitlyExpandDesignTimeFacades will not expand the facades and so we end up with no `netstandard.dll` reference! With `$(NETStandardInbox) == false`, `ImplicitlyExpandNETStandardFacades` behaves as if `netstandard.dll` was not available in the framework directories and will expand the facades if required. Partially fixes bxc #58504 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to handle the case of XM/Full project referencing a netstandard project.
For XM/Full, $(TargetFrameworkDirectory) is
lib/mono/4.5which hasnetstandard.dll. This causes ImplicitlyExpandNETStandardFacades toskip expanding assuming that when ImplicitlyExpandDesignTimeFacades
expands facades,
netstandard.dllwould also get referenced.But if the XM project does NOT have any System.Runtime facades, then
ImplicitlyExpandDesignTimeFacades will not expand the facades and so we
end up with no
netstandard.dllreference!With
$(NETStandardInbox) == false,ImplicitlyExpandNETStandardFacadesbehaves as ifnetstandard.dllwasnot available in the framework directories and will expand the facades
if required.