Bump to Xcode 9 beta 4 #2361
Merged
Bump to Xcode 9 beta 4 #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalexsoto
approved these changes
Jul 24, 2017
…eta4 (fix unit test)
There's no header change to mention `init` is not allowed but it's not clear how this default initializer could be used. Also make public some other API to construct this type (outside of XM). It's not clear why there were `internal` as they are (at least now) part of the header files.
|
Build failure |
|
first build hung... and was killed |
dalexsoto
approved these changes
Jul 24, 2017
| CIImageAccumulator FromRectangle (CGRect rect, int /* CIFormat = int */ ciImageFormat); | ||
|
|
||
| [iOS (9,0)] | ||
| [Static, Internal] | ||
| [Static] |
There was a problem hiding this comment.
Why was this promoted? just curious, could format be an enum somewhere?
There was a problem hiding this comment.
I have not yet gone to the root of this :)
It's not clear why those methods were half hidden (inconsistent) in XM and not exposed at all (unusable) in XI.
There was a problem hiding this comment.
| IntPtr Constructor (CGRect rectangle, int /* CIFormat = int */ ciImageFormat); | ||
|
|
||
| [Export ("initWithExtent:format:colorSpace:")][Internal] | ||
| [Export ("initWithExtent:format:colorSpace:")] |
There was a problem hiding this comment.
same, could format be an enum somewhere?
…ates Those tests were not added to validate xOS so just keep the parts that helps us (without constantly checking back the new break flavor)
|
2nd time hung too (same bat place) on the same bot, trying another one... |
|
Build failure |
|
Build failure |
|
Build success |
|
watchOS simulator issue filed in https://bugzilla.xamarin.com/show_bug.cgi?id=58348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.