Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for NativeAOT on macOS #18765

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Add support for NativeAOT on macOS #18765

merged 8 commits into from
Aug 30, 2023

Conversation

rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Aug 18, 2023 •
edited
Loading

Supersedes #18524.

@rolfbjarne rolfbjarne mentioned this pull request Aug 18, 2023
Closed
@rolfbjarne rolfbjarne added the do-not-merge Do not merge this pull request label Aug 18, 2023
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
filipnavara and others added 8 commits August 24, 2023 15:21
@filipnavara @rolfbjarne
Fix NSApplication.Init under NativeAOT
dff21a0
@filipnavara @rolfbjarne
[xharness] Enable NativeAOT tests on macOS
7e79bad 
Note that we’re forcing LinkMode=Full for monotouch-test, because  the project file
says "None", and that makes the ILC go into an infinite loop, so override that.
@filipnavara @rolfbjarne
Generate CopyWithZone without trampoline for MSR
446eb18
@filipnavara @rolfbjarne
Enable RegisterProtocols optimization on NativeAOT/macOS
b265305
@filipnavara @rolfbjarne
Update temp path calculation in Xamarin.Cache to work with NativeAOT
d8ede2c
@rolfbjarne
[tests] Ignore RegistrarTest.CustomUserTypeWithDynamicallyLoadedAssem…
1050c10 
…bly, it uses BCL API that doesn't work with NativeAOT.
@rolfbjarne
[tools] Don't not remove the dynamic registrar when using NativeAOT o…
c6041a3 
…n macOS.
@rolfbjarne
[src] Remove Runtime.GetNullableType from macOS in .NET.
67a5460 
Runtime.GetNullableType is only needed when loading mono dynamically, which is
only supported in legacy Xamarin.Mac.
@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [CI Build] Windows Integration Tests passed 💻

✅ All Windows Integration Tests passed.

Pipeline on Agent
Hash: 67a5460d61c183e6be915d9665e8194e35d8c5ec [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

📚 [PR Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS (no change detected)
  • tvOS (no change detected)
  • watchOS (no change detected)
  • macOS (no change detected)
NET (empty diffs)
  • iOS: (empty diff detected)
  • tvOS: (empty diff detected)
  • MacCatalyst: (empty diff detected)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 67a5460d61c183e6be915d9665e8194e35d8c5ec [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

✅ All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [PR build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator

🚀 [CI Build] Test results 🚀

Test results

✅ All tests passed on VSTS: simulator tests.

🎉 All 233 tests passed 🎉

Tests counts

✅ bcl: All 69 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests: All 1 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 7 tests passed. Html Report (VSDrops) Download
✅ framework: All 8 tests passed. Html Report (VSDrops) Download
✅ generator: All 2 tests passed. Html Report (VSDrops) Download
✅ interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download
✅ install_source: All 1 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker: All 65 tests passed. Html Report (VSDrops) Download
✅ mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download
✅ mmp: All 2 tests passed. Html Report (VSDrops) Download
✅ mononative: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch: All 39 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ mtouch: All 1 tests passed. Html Report (VSDrops) Download
✅ xammac: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 8 tests passed. Html Report (VSDrops) Download
✅ xtro: All 2 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 67a5460d61c183e6be915d9665e8194e35d8c5ec [PR build]

filipnavara
filipnavara approved these changes Aug 24, 2023
View reviewed changes
tools/common/Optimizations.cs Show resolved Hide resolved
@rolfbjarne rolfbjarne changed the title [DRAFT] Test PR 18524 with a few changes. Add support for NativeAOT on macOS Aug 25, 2023
@rolfbjarne rolfbjarne marked this pull request as ready for review August 25, 2023 06:19
@rolfbjarne rolfbjarne removed the do-not-merge Do not merge this pull request label Aug 25, 2023
@rolfbjarne rolfbjarne merged commit d50f52d into xamarin:net8.0 Aug 30, 2023
50 of 52 checks passed
@rolfbjarne rolfbjarne deleted the macos-nativeaot branch August 30, 2023 08:38
@ivanpovazan ivanpovazan mentioned this pull request Aug 31, 2023
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipnavara filipnavara filipnavara approved these changes

@dalexsoto dalexsoto dalexsoto approved these changes

@dustin-wojciechowski dustin-wojciechowski dustin-wojciechowski approved these changes

@mandel-macaque mandel-macaque Awaiting requested review from mandel-macaque mandel-macaque is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rolfbjarne @vs-mobiletools-engineering-service2 @dalexsoto @filipnavara @dustin-wojciechowski