[release/8.0.1xx-preview1] [dotnet-linker] Make this a .NET 7 app to work around the fact that the linker is still a .NET 7 app. #17560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work around the fact that the linker is still a .NET 7 app. Hopefully works around dotnet/runtime#82241.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Feb 16, 2023
Context: xamarin/xamarin-macios#17560 Context: dotnet/runtime#82241 On macOS, if you have both .NET 7 and .NET 8 Preview 1 installed, and you do: * `dotnet new android` * `dotnet build -c Release` You get a build error: Fatal error in IL Linker Unhandled exception. System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' at Microsoft.Android.Sdk.ILLink.PreserveSubStepDispatcher..ctor() at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) --- End of inner exception stack trace --- at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) at Mono.Linker.Driver.AddCustomStep(Pipeline pipeline, String arg) at Mono.Linker.Driver.SetupContext(ILogger customLogger) at Mono.Linker.Driver.Run(ILogger customLogger) at Mono.Linker.Driver.Main(String[] args) This happens because the linker is actually trying to run against the .NET 7 runtime! It promptly blows up against `net8.0` linker steps. Trying the same workaround as xamarin-macios, to build our linker steps for `net7.0`
dalexsoto
approved these changes
Feb 16, 2023
haritha-mohan
approved these changes
Feb 16, 2023
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Feb 17, 2023
Context: xamarin/xamarin-macios#17560 Context: dotnet/runtime#82241 On macOS, if you have both .NET 7 and .NET 8 Preview 1 installed, and you do: dotnet new android dotnet build -c Release You get a build error: Fatal error in IL Linker Unhandled exception. System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' at Microsoft.Android.Sdk.ILLink.PreserveSubStepDispatcher..ctor() at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) --- End of inner exception stack trace --- at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) at Mono.Linker.Driver.AddCustomStep(Pipeline pipeline, String arg) at Mono.Linker.Driver.SetupContext(ILogger customLogger) at Mono.Linker.Driver.Run(ILogger customLogger) at Mono.Linker.Driver.Main(String[] args) This happens because the .NET 8 linker is actually trying to run against the .NET 7 runtime! It promptly blows up against `net8.0` linker steps. Trying [the same workaround as xamarin-macios][0], to build our linker steps for `net7.0`. [0]: xamarin/xamarin-macios@c61e327
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Feb 17, 2023
Context: xamarin/xamarin-macios#17560 Context: dotnet/runtime#82241 On macOS, if you have both .NET 7 and .NET 8 Preview 1 installed, and you do: dotnet new android dotnet build -c Release You get a build error: Fatal error in IL Linker Unhandled exception. System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' at Microsoft.Android.Sdk.ILLink.PreserveSubStepDispatcher..ctor() at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) --- End of inner exception stack trace --- at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) at Mono.Linker.Driver.AddCustomStep(Pipeline pipeline, String arg) at Mono.Linker.Driver.SetupContext(ILogger customLogger) at Mono.Linker.Driver.Run(ILogger customLogger) at Mono.Linker.Driver.Main(String[] args) This happens because the .NET 8 linker is actually trying to run against the .NET 7 runtime! It promptly blows up against `net8.0` linker steps. Trying [the same workaround as xamarin-macios][0], to build our linker steps for `net7.0`. [0]: xamarin/xamarin-macios@c61e327
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully works around dotnet/runtime#82241.