-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0.1xx-preview1] [dotnet-linker] Make this a .NET 7 app to work around the fact that the linker is still a .NET 7 app. #17560
Conversation
…work around the fact that the linker is still a .NET 7 app. Hopefully works around dotnet/runtime#82241.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Context: xamarin/xamarin-macios#17560 Context: dotnet/runtime#82241 On macOS, if you have both .NET 7 and .NET 8 Preview 1 installed, and you do: * `dotnet new android` * `dotnet build -c Release` You get a build error: Fatal error in IL Linker Unhandled exception. System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' at Microsoft.Android.Sdk.ILLink.PreserveSubStepDispatcher..ctor() at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) --- End of inner exception stack trace --- at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) at Mono.Linker.Driver.AddCustomStep(Pipeline pipeline, String arg) at Mono.Linker.Driver.SetupContext(ILogger customLogger) at Mono.Linker.Driver.Run(ILogger customLogger) at Mono.Linker.Driver.Main(String[] args) This happens because the linker is actually trying to run against the .NET 7 runtime! It promptly blows up against `net8.0` linker steps. Trying the same workaround as xamarin-macios, to build our linker steps for `net7.0`
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)✅ Generator diffGenerator diff is empty Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 225 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Context: xamarin/xamarin-macios#17560 Context: dotnet/runtime#82241 On macOS, if you have both .NET 7 and .NET 8 Preview 1 installed, and you do: dotnet new android dotnet build -c Release You get a build error: Fatal error in IL Linker Unhandled exception. System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' at Microsoft.Android.Sdk.ILLink.PreserveSubStepDispatcher..ctor() at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) --- End of inner exception stack trace --- at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) at Mono.Linker.Driver.AddCustomStep(Pipeline pipeline, String arg) at Mono.Linker.Driver.SetupContext(ILogger customLogger) at Mono.Linker.Driver.Run(ILogger customLogger) at Mono.Linker.Driver.Main(String[] args) This happens because the .NET 8 linker is actually trying to run against the .NET 7 runtime! It promptly blows up against `net8.0` linker steps. Trying [the same workaround as xamarin-macios][0], to build our linker steps for `net7.0`. [0]: xamarin/xamarin-macios@c61e327
Context: xamarin/xamarin-macios#17560 Context: dotnet/runtime#82241 On macOS, if you have both .NET 7 and .NET 8 Preview 1 installed, and you do: dotnet new android dotnet build -c Release You get a build error: Fatal error in IL Linker Unhandled exception. System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' at Microsoft.Android.Sdk.ILLink.PreserveSubStepDispatcher..ctor() at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) --- End of inner exception stack trace --- at System.RuntimeType.CreateInstanceDefaultCtor(Boolean publicOnly, Boolean wrapExceptions) at Mono.Linker.Driver.AddCustomStep(Pipeline pipeline, String arg) at Mono.Linker.Driver.SetupContext(ILogger customLogger) at Mono.Linker.Driver.Run(ILogger customLogger) at Mono.Linker.Driver.Main(String[] args) This happens because the .NET 8 linker is actually trying to run against the .NET 7 runtime! It promptly blows up against `net8.0` linker steps. Trying [the same workaround as xamarin-macios][0], to build our linker steps for `net7.0`. [0]: xamarin/xamarin-macios@c61e327
Hopefully works around dotnet/runtime#82241.