Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some whitespace issues in various files. #12399

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

rolfbjarne
Copy link
Member

  • Remove BOM
  • Add EOL at end of file.

* Remove BOM
* Add EOL at end of file.
@spouliot
Copy link
Contributor

1700 files !?!

@mandel-macaque
Copy link
Member

lol I get a 500 error

@mandel-macaque
Copy link
Member

I would approve if github did not returned a 500 when I want to give a +1 :/

@tj-devel709
Copy link
Contributor

Just making sure, this was done with a script and not manually, right!?

@mandel-macaque
Copy link
Member

@tj-devel709 you can do things like:

sed -i '1s/^\xEF\xBB\xBF//' orig.txt

That will remove the BOM, you can iterate over all files, similar, you can do:

sed -i '' -e '$a\' file

Combine both and done

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (only version changes)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

1 tests failed, 190 tests passed.

Failed tests

  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed

Pipeline on Agent XAMBOT-1096.BigSur'
Merge 41cc900 into 300fc28

@rolfbjarne
Copy link
Member Author

@rolfbjarne rolfbjarne merged commit 2972e1b into xamarin:main Aug 11, 2021
@rolfbjarne rolfbjarne deleted the whitespace branch August 11, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-notes-worthy Ignore for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants