Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono2018-06]mini test failure with mono2018-06 #4618

Closed
GouriKumari opened this issue Aug 14, 2018 · 3 comments
Closed

[mono2018-06]mini test failure with mono2018-06 #4618

GouriKumari opened this issue Aug 14, 2018 · 3 comments
Labels
bug If an issue is a bug or a pull request a bug fix iOS Issues affecting iOS
Milestone
d16-0

Comments

@GouriKumari
Copy link
Contributor

Steps to Reproduce

  1. Update System to Xamarin.iOS from mono2018-06 branch, XI version: 11.15.0.48 (PR-4277: 3901d8e)
  2. Execute mini tests on a device. Tests executed on a 32 bit device with iOS version 9.3.5

Expected Behavior

All tests should pass

Actual Behavior

[FAIL] JitTests.Objects : Expected: 0

Environment

Mono version: 5.16.0.108 (7a9c54ebd45)  (2018-08-13 12:19:08 -04:00)
XI version: 11.15.0.48 (PR-4277: 3901d8e2) 
XM version: 4.7.0.48 (3901d8e2)  (2018-08-08 06:27:48 -04:00)
XS version: 7.7.0.830 (2dac6bd)  (2018-08-13 12:35:26 -04:00)

Build Logs

Build Log: http://xqa.blob.core.windows.net/gist/report-f43437d114b945608b86a397311eeabf.txt
Test Log: http://xqa.blob.core.windows.net/gist/mscorlib-tvos06-15-2985652fd1ecb4eddd80ebefb1562b316473fa559b06-15-29-5fa48680f8244f2eb519b3941b11efe5.zip

Example Project (If Possible)

xamarin-macios/tests/mini/mini-ios
@GouriKumari GouriKumari changed the title [mono2018-06]mini test failure on an iOS device [mono2018-06]mini test failure with mono2018-06 Aug 14, 2018
@spouliot spouliot mentioned this issue Aug 14, 2018
Merged
@mandel-macaque mandel-macaque added the iOS Issues affecting iOS label Aug 14, 2018
@mandel-macaque mandel-macaque added this to the d15-9 milestone Aug 14, 2018
@lewurm
Copy link
Contributor

lewurm commented Aug 14, 2018

maybe related mono/mono#10096

@vargaz
Copy link
Contributor

vargaz commented Aug 14, 2018

Will be fixed by
mono/mono#10096

vargaz added a commit to vargaz/mono that referenced this issue Aug 14, 2018
@vargaz
[jit] Fix a constant propagation problem on 32 bit with iconst+conv.i…
7d469f9 
…8, we would be setting inst_imm even for long opcodes.

Fixes xamarin/xamarin-macios#4618.
This was referenced Aug 14, 2018
Merged
Closed
marek-safar pushed a commit to mono/mono that referenced this issue Aug 29, 2018
@vargaz @marek-safar
[2018-06] [jit] Fix a constant propagation problem on 32 bit with ico…
f9c42ea 
…nst+conv.i… (#10102)

* [jit] Fix a constant propagation problem on 32 bit with iconst+conv.i8, we would be setting inst_imm even for long opcodes.

Fixes xamarin/xamarin-macios#4618.

* [llvm] Fix the special casing of OP_LCOMPARE_IMM, its not needed.
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Sep 3, 2018
@rolfbjarne rolfbjarne modified the milestones: d15-9, d16-0 Sep 18, 2018
@lewurm lewurm reopened this Oct 9, 2018
@spouliot
Copy link
Contributor

mono 2018-06 was merged in master
The mini tests now run successfully on 32 bits

@ghost ghost locked as resolved and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug If an issue is a bug or a pull request a bug fix iOS Issues affecting iOS
Projects
None yet
Milestone
d16-0
Development

No branches or pull requests
6 participants
@lewurm @vargaz @rolfbjarne @spouliot @GouriKumari @mandel-macaque