Skip to content

Commit

Permalink
[xcode12.3] Update NuGet feed (#10601)
Browse files Browse the repository at this point in the history
bump maccore for dependencies updates

New commits in xamarin/maccore:

* xamarin/maccore@722e62d680 Remove dependency on XmlDocSync repo/tools (#2393)
* xamarin/maccore@f3d1b21947 Update NuGet.config to enforce a single feed (#2374)

Diff: https://github.com/xamarin/maccore/compare/77a7f937d8d54b3c7f8eb13602831205fd2a28db..722e62d68045cb7257043c5969ad31dba4038a28

* Disable dotnet (and related tests from release branch)

* [xharness] Forcefully disable .NET tests.

* Exclude more .NET stuff.

* Ignore dotnet (if not enabled) for tests

Co-authored-by: Sebastien Pouliot <[email protected]>
Co-authored-by: Rolf Bjarne Kvinge <[email protected]>
  • Loading branch information
3 people authored Feb 11, 2021
1 parent 0bd8fae commit d7eb625
Show file tree
Hide file tree
Showing 7 changed files with 23 additions and 9 deletions.
6 changes: 5 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
TOP=.
SUBDIRS=builds runtime fsharp src msbuild tools dotnet
SUBDIRS=builds runtime fsharp src msbuild tools
include $(TOP)/Make.config
include $(TOP)/mk/versions.mk

ifdef ENABLE_DOTNET
SUBDIRS += dotnet
endif

#
# Common
#
Expand Down
8 changes: 7 additions & 1 deletion NuGet.config
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,14 @@
<add key="repositorypath" value="packages" />
</config>
<packageSources>
<add key="Nuget Official" value ="https://www.nuget.org/api/v2/" />
<clear />
<add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" protocolVersion="3" />
<add key="Dotnet arcade" value ="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json" />
<add key="dotnet6" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json" />
<add key="dotnet5" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json" />
</packageSources>
<disabledPackageSources>
<clear />
</disabledPackageSources>
</configuration>

4 changes: 2 additions & 2 deletions jenkins/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,8 @@ if test -z "$ENABLE_DEVICE_BUILD"; then
CONFIGURE_FLAGS="$CONFIGURE_FLAGS --disable-ios-device"
fi

# Enable dotnet bits on the bots
CONFIGURE_FLAGS="$CONFIGURE_FLAGS --enable-dotnet --enable-install-source"
# Disable dotnet bits on the bots (only useful in 'main' right now)
CONFIGURE_FLAGS="$CONFIGURE_FLAGS --disable-dotnet --enable-install-source"

echo "Configuring the build with: $CONFIGURE_FLAGS"
# shellcheck disable=SC2086
Expand Down
2 changes: 1 addition & 1 deletion mk/xamarin.mk
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ MONO_BRANCH := $(shell cd $(MONO_PATH) 2> /dev/null && git symbolic-ref --sho
endif

ifdef ENABLE_XAMARIN
NEEDED_MACCORE_VERSION := 77a7f937d8d54b3c7f8eb13602831205fd2a28db
NEEDED_MACCORE_VERSION := 722e62d68045cb7257043c5969ad31dba4038a28
NEEDED_MACCORE_BRANCH := d16-8

MACCORE_DIRECTORY := maccore
Expand Down
6 changes: 5 additions & 1 deletion tests/Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
TOP = ..
SUBDIRS=test-libraries dotnet
SUBDIRS=test-libraries

ifdef ENABLE_DOTNET
SUBDIRS += dotnet
endif

# disabled for now: mac-test

Expand Down
4 changes: 2 additions & 2 deletions tests/xharness/Jenkins/TestSelector.cs
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ void SelectTestsByModifiedFiles (int pullRequest)
SetEnabled (files, macBindingProject, "mac-binding-project", ref jenkins.IncludeMacBindingProject);
SetEnabled (files, xtroPrefixes, "xtro", ref jenkins.IncludeXtro);
SetEnabled (files, cecilPrefixes, "cecil", ref jenkins.IncludeCecil);
SetEnabled (files, dotnetFilenames, "dotnet", ref jenkins.IncludeDotNet);
// SetEnabled (files, dotnetFilenames, "dotnet", ref jenkins.IncludeDotNet);
}

void SelectTestsByLabel (int pullRequest)
Expand Down Expand Up @@ -234,7 +234,7 @@ void SelectTestsByLabel (int pullRequest)
SetEnabled (labels, "xtro", ref jenkins.IncludeXtro);
SetEnabled (labels, "cecil", ref jenkins.IncludeCecil);
SetEnabled (labels, "old-simulator", ref jenkins.IncludeOldSimulatorTests);
SetEnabled (labels, "dotnet", ref jenkins.IncludeDotNet);
// SetEnabled (labels, "dotnet", ref jenkins.IncludeDotNet);
SetEnabled (labels, "all", ref jenkins.IncludeAll);

// enabled by default
Expand Down
2 changes: 1 addition & 1 deletion tools/devops/automation/templates/build/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ steps:
CONFIGURE_FLAGS="--enable-xamarin"
fi
CONFIGURE_FLAGS="$CONFIGURE_FLAGS --enable-dotnet --enable-install-source"
CONFIGURE_FLAGS="$CONFIGURE_FLAGS --disable-dotnet --enable-install-source"
cd $(Build.SourcesDirectory)/xamarin-macios/
./configure $CONFIGURE_FLAGS
Expand Down

4 comments on commit d7eb625

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on Build ❌

Tests failed on Build.

View packages

Test results

2 tests failed, 153 tests passed.

Failed tests

  • introspection/watchOS 32-bits - simulator/Debug (watchOS 3.2): Crashed
  • MTouch tests/NUnit: Failed (Execution failed with exit code 5)

Pipeline on Agent XAMBOT-1106

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS32b (no summary found). 🔥

Result file $(TEST_SUMMARY_PATH) not found.

Pipeline on Agent

Please sign in to comment.