This repository has been archived by the owner on Apr 29, 2024. It is now read-only.
[SoupChef] Fix build with Xcode 12.2 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode 12.2 - adds `arm64` to the simulator architectures - removes `i386` from the simulator architectures `lipo` cannot create a _classic_ fat archive with `arm64` simulator and `arm64` device slices - since they are the same architecture. This requires `.xcframework` support which is not yet supported by XI and XM. However we can tweak the build to do: - x86_64 only for simulator, which is the only support arch for XI today - arm64 for devices and that makes `lipo` happy and we can continue to have this sample under test automation. Note: the original `.a` names were incorrect as they did not match the architectures that were present in the files. I changed them to mention the platform.
dalexsoto
approved these changes
Oct 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 12.2
arm64to the simulator architecturesi386from the simulator architectureslipocannot create a classic fat archive witharm64simulator andarm64device slices - since they are the same architecture.This requires
.xcframeworksupport which is not yet supported by XIand XM.
However we can tweak the build to do:
and that makes
lipohappy and we can continue to have this sample undertest automation.
Note: the original
.anames were incorrect as they did not match thearchitectures that were present in the files. I changed them to mention
the platform.