This repository was archived by the owner on May 1, 2024. It is now read-only.
[XamlC] cache ImportReference and ImportMethodReference as they're slow #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
added
the
DO-NOT-MERGE-!!! 🛑
StephaneDelcroix
force-pushed
the
xamlc_ns14
branch
from
172fb92 to
34793bd
Compare
StephaneDelcroix
removed
the
DO-NOT-MERGE-!!! 🛑
jassmith
approved these changes
Apr 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[XamlC] cache ImportReference and ImportMethodReference as they're slow
on ns1.4
XamlC perf report
Project: SmartHotels.Client (
ea3dd73)msbuild /v:diag /t:rebuildMac
netstandard1.42.5.0(pre-netstandard)3.0.0-pre2(some perf work already in)"https://github.com/xamarin/Xamarin.Forms/pull/2025"netstandard2.02.5.0(pre-netstandard)3.0.0-pre2(some perf work already in)https://github.com/xamarin/Xamarin.Forms/pull/2025""Win
netstandard1.42.5.0(pre-netstandard)3.0.0-pre2(some perf work already in)"https://github.com/xamarin/Xamarin.Forms/pull/2025"netstandard2.02.5.0(pre-netstandard)3.0.0-pre2(some perf work already in)https://github.com/xamarin/Xamarin.Forms/pull/2025