This repository has been archived by the owner on May 1, 2024. It is now read-only.
[XamlC] no longer use any reflection-base ImportReference #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
force-pushed
the
xamlc_noreflection
branch
2 times, most recently
from
03c9073 to
ca121ef
Compare
jassmith
approved these changes
Feb 16, 2018
StephaneDelcroix
added
the
DO-NOT-MERGE-!!! 🛑
StephaneDelcroix
removed
the
DO-NOT-MERGE-!!! 🛑
reflection-base ImportReference -- we were using MethodBase and Type -- are importing the types present in the reflection context, at the time of compilation. As the compilation happens on netstandard2.0, and our assembly can now be netstandard1.0 again, those imported types are failing to be resolved. this changes always import references based on the assembly, or the assembly references. it might, or might not, give us another speed bump.
StephaneDelcroix
force-pushed
the
xamlc_noreflection
branch
from
423d2bb to
d73815f
Compare
jassmith
approved these changes
Feb 22, 2018
|
Will get you benchmark times tomorrow |
|
For the latest PR and with that I'm able to compile netstandard 1.4 with the following build times Against netstandard 2.0 I have the following build times |
samhouts
approved these changes
Feb 23, 2018
| //I hate you, netstandard | ||
| if (type.assemblyName == "mscorlib" && type.clrNamespace == "System.Reflection") | ||
| return module.GetTypeDefinition(("System.Reflection", type.clrNamespace, type.typeName)); | ||
| throw new Exception($"Failed to get typedef for {type}"); |
There was a problem hiding this comment.
👮 This LOOKS like this exception happens as part of this if clause because of the indentation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[XamlC] no longer use any reflection-base ImportReference
reflection-base ImportReference -- we were using MethodBase and Type --
are importing the types present in the reflection context, at the time
of compilation. As the compilation happens on netstandard2.0, and our
assembly can now be netstandard1.0 again, those imported types are
failing to be resolved.
this changes always import references based on the assembly, or the
assembly references.
it might, or might not, give us another speed bump.
PR Checklist