This repository was archived by the owner on May 1, 2024. It is now read-only.
Conversation
hartez
added
blocker
jsuarezruiz
approved these changes
Feb 2, 2021
Contributor
|
The failing tests seem to be unrelated ( |
Contributor
Author
The iOS 14 failures in the Bugzilla tests are unrelated, but the iOS 13 test failure is definitely real; looking into it now. |
Contributor
Author
|
Closing this in favor of #13640. |
samhouts
added
i/high
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
#13370 added a watch for the IsVisible property change to signal a layout request to the UICollectionView control. Since it was 4.8 and using the old deferred layout resolution, there was no need to signal to Forms layouts that a layout update was necessary, as a re-layout due to the IsVisible change was already on the queue.
In 5.0 layout resolution is on-demand, so the UICollectionView's LayoutIfNeeded must be called to signal that a full layout is due. These changes add that call, and automated tests to verify that visibility changes work for a CollectionView inside of a Layout where the visibility is determined by a DataTrigger or IValueConverter.
Issues Resolved
IsVisiblemodified via a binding/trigger #13551API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Automated UI test
PR Checklist