Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Update some project files to SDK-style. #2

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

jpobst
Copy link

@jpobst jpobst commented Feb 9, 2021

Update ICSharpCode.NRefactory.csproj and ICSharpCode.NRefactory.CSharp.csproj to SDK style projects.

The unit tests in Xamarin.Android use these assemblies along with the Mono debugging assemblies to ensure that changes do not break the ability to debug XA applications.

In order to target .NET 5/6 we need to build with dotnet build, which requires SDK style projects.

There does not seem to be CI for this repo. I tested by building locally as well as running the XA CI against this change: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4453779.

@jpobst
Copy link
Author

jpobst commented Feb 9, 2021

@KirillOsenkov You touched this repo last! Can you review and merge this? Or point me to someone who can? Thanks!

<ProductVersion>8.0.30703</ProductVersion>
<SchemaVersion>2.0</SchemaVersion>
<SignAssembly>true</SignAssembly>
<TargetFramework>net40</TargetFramework>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to target net40? Ideally it's net472.

Copy link
Member

@KirillOsenkov KirillOsenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it builds, it's good!

@KirillOsenkov KirillOsenkov merged commit 495405a into xamarin:master Feb 9, 2021
@jpobst jpobst deleted the sdk-style branch February 9, 2021 20:21
@jpobst
Copy link
Author

jpobst commented Feb 9, 2021

Thanks! net40 was just existing I think, and no one wants to make actual changes to these files. 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants