This repository was archived by the owner on May 15, 2024. It is now read-only.
Fix crash when using WebAuthenticator.AuthenticateAsync #1586#1687
Merged
mattleibow merged 1 commit intoxamarin:mainfrom Feb 10, 2021
Merged
Conversation
mattleibow
approved these changes
Feb 10, 2021
Collaborator
|
LGTM |
dimonovdd
added a commit
to dimonovdd/Essentials
that referenced
this pull request
Feb 13, 2021
* main: Fix crash when using WebAuthenticator.AuthenticateAsync xamarin#1586 (xamarin#1687)
dimonovdd
added a commit
to dimonovdd/Essentials
that referenced
this pull request
Feb 13, 2021
* main: Fix crash when using WebAuthenticator.AuthenticateAsync xamarin#1586 (xamarin#1687) Ensure granted (xamarin#1658)
|
@mattleibow, could you tell when will this changes be released? |
|
Hi @mattleibow @jamesmontemagno ! |
|
Woohoo ! Thanks to all the team @jamesmontemagno 💪 |
CartBlanche
pushed a commit
to CartBlanche/Essentials
that referenced
this pull request
Sep 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix crash when using WebAuthenticator.AuthenticateAsync in latest version. While this might not be the best way to fix it, it fixes the issue (at least on our app). If a different fix is required, can this at least be given some priority? Thanks
No tests are added because I have no idea how I'd even write a test for this case
Bugs Fixed
API Changes
None
Behavioral Changes
None