should fix issue 660 #780
Merged
should fix issue 660 #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0psicles
reviewed
Dec 22, 2020
src/components/VgtFilterRow.vue
Outdated
| @@ -134,6 +137,10 @@ export default { | |||
| return placeholder; | |||
| }, | |||
|
|
|||
| getName(column) { | |||
| return `vgt-' + ${column.field}`; | |||
There was a problem hiding this comment.
Im not the project owner. But I noticed this. Your mixing template strings with + '
There was a problem hiding this comment.
Thanks for noticing, I've fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add name attribute to filters input with the following pattern :
`vgt-${column.field}`Previously, the only way to have access to a specific filter was
'input[placeholder="Search"]'.We can now use
'input[name="vgt-field1"]', that is a better opotion as "name" attribute should be unique in most cases.This addresses #660