Align MSVC hardening with ONNX Runtime Spectre runtime-library handling - #3361
Merged
Conversation
Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com>
Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Resolve applicability to onnx-light for PR 29624
Align MSVC hardening with ONNX Runtime Spectre runtime-library handling
Jul 11, 2026
xadupre
approved these changes
Jul 11, 2026
xadupre
marked this pull request as ready for review
July 11, 2026 12:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ONNX_HARDENING=ONalready enabled/Qspectreon MSVC, but it did not ensure the link step also picked the Spectre-mitigated CRT/STL libraries. This mirrors the relevant part of the upstream ONNX Runtime change so Windows hardening builds do not advertise Spectre mitigation while still linking the default runtime libraries.MSVC hardening
VCToolsInstallDirx86,x64,arm,arm64,arm64ec)/Qspectreis active, prependslib/spectre/<arch>to the linker search patharm64ectoarm64when that is how the toolset ships the Spectre libsFailure mode
/Qspectreis enabled but the Spectre-mitigated MSVC runtime libraries are not installedDocumentation
/QspectrebehaviorExample of the new behavior in the hardening path: