Repository navigation
fix(a11y): name the post's star counter with its visible count - #270
Merged
Merged
Conversation
Same defect #267 fixed on the header's GithubStars trigger, in the blog post's StarCounter link: its `aria-label` ("Star this repository on GitHub") replaced the visible count, which axe-core 4.14 reports as `label-content-name-mismatch` (WCAG 2.5.3). The gate only caught it on #268, because the accessibility suite hits the live GitHub API: while that request was rate-limited the counter showed an error glyph with no visible text and there was nothing to mismatch; the first run that got a count went red. The label is now visually hidden text inside the link, so the name reads "Star this repository on GitHub 22" and no longer depends on the request. `.visuallyHidden` is absolutely positioned, so the flex row keeps its layout.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
xabierlameiro
marked this pull request as ready for review
October 25, 2026 12:30
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same defect #267 fixed on the header's GithubStars trigger, in the blog post's
StarCounterlink: itsaria-labelreplaced the visible count, which axe-core 4.14 reports aslabel-content-name-mismatch(WCAG 2.5.3).It surfaced on #268's
Testingjob and not on #267's because the accessibility suite hits the live GitHub API: while that request is rate-limited the counter shows an error glyph with no visible text, so there is nothing to mismatch, and the first run that got a count went red. The failure is environment-dependent, which is why it gets its own small PR rather than riding a dependency bump.The label is now visually hidden text inside the link (name reads "Star this repository on GitHub 22"), with the assertion added to the unit test. No layout change:
.visuallyHiddenis absolutely positioned and takes no flex slot.Merge before #268 and #269; both get synced with
masterafterwards so their gates re-run.Generated by Claude Code