Repository navigation
fix(deps): patch dev-tooling advisories (brace-expansion, wdm, fast-uri) - #245
Merged
Merged
Conversation
Dependabot alerts opened on the merge of #241, all dev-only: - webpack-dev-middleware 6.1.3 -> 8.3.0 (GHSA-g84c-rxfj-3j2c, high), scoped override under @storybook/builder-webpack5. Storybook still pins ^6.1.2 (10.6.1 and 11.0.0-alpha.1) and 6.x has no fix; this mirrors storybookjs/storybook#36521, which bumps to ^8.3.0 with no source changes. Our webpack 5.108.4 meets the ^5.101.0 peer. - brace-expansion overrides 1.1.18 -> 1.1.21 and 5.0.9 -> 5.0.12 (GHSA-q2hr-2g5m-vwhr). - fast-uri 3.1.7 -> 3.1.8 within range (GHSA-hrr3-gc8f-f4qj). The lockfile also regains `dev: true` on ~70 webpack dependencies. #243's Dependabot regeneration ran without --legacy-peer-deps and dropped them, which made audit:prod count them as production.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript |  |
Oct 1, 2026 7:46p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Dependabot alerts that opened when #241 merged. All of them are dev-only (Storybook, jest, eslint, jsdoc), which is why
audit:proddid not catch them.webpack-dev-middleware(Storybook)@storybook/builder-webpack5brace-expansionfast-urimarkdown-itWhy the
webpack-dev-middlewareoverrideStorybook still pins
^6.1.2in 10.6.1 and 11.0.0-alpha.1, and 6.x has no fix. The override does what storybookjs/storybook#36521 (open) does: it bumps to^8.3.0with no source changes. Our webpack 5.108.4 meets the^5.101.0peer. Drop the override once Storybook ships the bump.Lockfile
devflagsAbout 70 webpack dependencies get
dev: trueback. #243's Dependabot regeneration ran without--legacy-peer-depsand removed it, soaudit:prodwas counting them as production. The count goes 1082 before #243, 1012 after it, and 1109 here; the extra 27 are memfs 4 and its dependencies.Verification (local)
npm audit: none of the three advisories remain. Only the 6 lowellipticfindings are left, already dismissed as tolerable risk.npm run audit:prod: passes.storybook dev --smoke-testandstorybook buildpass./iframe.html,/index.htmland the main bundle return 200./..%2f..%2fpackage.jsonreturns 403.