Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elytrafly speed calculation issue / [request] #184

Closed
AAlchemy opened this issue Jan 24, 2024 · 8 comments
Closed

elytrafly speed calculation issue / [request] #184

AAlchemy opened this issue Jan 24, 2024 · 8 comments

Comments

@AAlchemy
Copy link

Some clients fly a bit faster in vertical-diagonal flight (changing altitude while flying horizontal).
e.g. if client efly is set to 3.3 on horizontal and vertical, in testing, diagonal speed will be 3.69 . Granted this is technically a client issue, would it be possible to check if the client is moving +-Y while also moving in (X or Z) and if they are, have an additional speed limit setting? To account for clients failing to fully abide by their own speed settings?

@AAlchemy
Copy link
Author

correction! it's actually AEF that's calculating wrong. in-client speedometer says the speed is consistent

@xGinko
Copy link
Owner

xGinko commented Jan 24, 2024

Test the latest build in the action run and see if that fixes the problem with the y-range speed detection. The current solution that can somewhat correctly calculate speed for speedhackers is not very accurate and only gets accurate when there is none used

@xGinko
Copy link
Owner

xGinko commented Jan 24, 2024

@AAlchemy
Copy link
Author

It still reads a 3.3 client speed as 3.69 in the diagonal direction. so strange. We could do some more real time trial and error testing on discord tomorrow, if you want. Since I can reproduce the issue, and have a test server.

@AAlchemy
Copy link
Author

maybe just a setting to be able to toggle back to the old speed check? a disable vertical check option

@xGinko
Copy link
Owner

xGinko commented Jan 27, 2024

@AAlchemy I added your suggestion, try if that changes anything. Do note though that I tested this with ElytraFly on meteor (mode VANILLA) and no matter the calculation method, actionbar returns the correct speed. There is a possibility that the elytrafly on your client does something special

xGinko added a commit that referenced this issue Jan 27, 2024
@AAlchemy
Copy link
Author

AAlchemy commented Feb 2, 2024

That new 3d/2d speed check toggle works. It stops the issues my users were seeing. Thanks for that. You are the best!

@AAlchemy AAlchemy closed this as completed Feb 2, 2024
@ghost
Copy link

ghost commented Feb 2, 2024

xGinko ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants