Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README #127

Merged
merged 3 commits into from
Oct 14, 2021
Merged

update README #127

merged 3 commits into from
Oct 14, 2021

Conversation

chengzhuzhang
Copy link
Collaborator

Add acknowledgement and LLNL release code.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #127 (11888b4) into main (21dad38) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #127   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          336       336           
=========================================
  Hits           336       336           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21dad38...11888b4. Read the comment docs.

@chengzhuzhang
Copy link
Collaborator Author

@tomvothecoder hey, i fixed the pre-commit error, but now stuck with a build error not sure how to fix...

@tomvothecoder
Copy link
Collaborator

Thanks for this PR Jill. It looks like a codecov report uploading issue, which I'll handle.

@tomvothecoder
Copy link
Collaborator

I added some minor fixes and badges to the README.rst.

The codecov uploader issue is being addressed right now. We can wait until it is fixed before merging.
Related issue: codecov/codecov-action#557

Copy link
Collaborator

@pochedls pochedls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this README looks good. Ideally in the future we will be able to include and welcome external contributions.

@chengzhuzhang
Copy link
Collaborator Author

Thank you @tomvothecoder. @pochedls Yes, I think so too!

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@tomvothecoder tomvothecoder merged commit 6580540 into main Oct 14, 2021
@tomvothecoder tomvothecoder deleted the update_readme branch October 14, 2021 20:41
@tomvothecoder tomvothecoder added Priority: Medium type: docs Updates to documentation labels Oct 15, 2021
@tomvothecoder tomvothecoder self-assigned this Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Updates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants