fix(64864): followup - #34
Open
x7peeps wants to merge 2 commits into
Open
Conversation
…handler
query_document_meta and batch_query_comment run in parallel via gather.
Without return_exceptions=True, a single fetch failure crashes the entire
handler, losing the other result. Use return_exceptions=True and handle
each result independently — falling back to {} on exception while keeping
the successful result.
Add regression tests for each fetch raising independently, asserting the
other result is retained and the handler continues.
Closes NousResearch#64864
…search#64864) Add focused tests for each fetch raising independently through the actual gather pattern used in handle_drive_comment_event: - Meta fetch failure: asserts comment result is preserved - Comment fetch failure: asserts meta result is preserved - Both succeed: baseline test Each test exercises the return_exceptions=True pattern and the subsequent isinstance checks that isolate failures. Refs: NousResearch#64864
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated PR from branch
Commit: 1ab0b3d test(feishu): add gather exception isolation regression tests (NousResearch#64864)