docs(specs): fix broken link to batch-settlement spec in cloudflare scheme - #2438
Merged
phdargen merged 1 commit intoMay 26, 2026
Conversation
|
@chopmob-cloud is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Hi @chopmob-cloud, we require commit signing, happy to merge once you rebase with signed commits :) |
chopmob-cloud
force-pushed
the
fix/batch-settlement-cloudflare-doc-link
branch
from
May 23, 2026 09:10
0a9c64b to
475577c
Compare
Contributor
Author
phdargen
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
specs/schemes/batch-settlement/scheme_batch_settlement_cloudflare.mdlinks to./batch_settlement.md#credit-backed, but nobatch_settlement.mdexists in that directory. The file isscheme_batch_settlement.md, so the link 404s on GitHub.This points the link (and its label, for consistency) at
./scheme_batch_settlement.md#credit-backed. The#credit-backedanchor is unchanged and already resolves to the### Credit-backedheading in that file.Tests
Docs-only change. Verified
specs/schemes/batch-settlement/scheme_batch_settlement.mdexists in the same directory and contains a### Credit-backedheading, so the corrected link and its anchor both resolve.Checklist
Note: the commit is currently unsigned; happy to rebase with a signed commit if needed before merge.