Skip to content

docs(specs): fix broken link to batch-settlement spec in cloudflare scheme - #2438

Merged
phdargen merged 1 commit into
x402-foundation:mainfrom
chopmob-cloud:fix/batch-settlement-cloudflare-doc-link
May 26, 2026
Merged

docs(specs): fix broken link to batch-settlement spec in cloudflare scheme#2438
phdargen merged 1 commit into
x402-foundation:mainfrom
chopmob-cloud:fix/batch-settlement-cloudflare-doc-link

Conversation

@chopmob-cloud

@chopmob-cloud chopmob-cloud commented May 22, 2026

Copy link
Copy Markdown
Contributor

Description

specs/schemes/batch-settlement/scheme_batch_settlement_cloudflare.md links to ./batch_settlement.md#credit-backed, but no batch_settlement.md exists in that directory. The file is scheme_batch_settlement.md, so the link 404s on GitHub.

This points the link (and its label, for consistency) at ./scheme_batch_settlement.md#credit-backed. The #credit-backed anchor is unchanged and already resolves to the ### Credit-backed heading in that file.

Tests

Docs-only change. Verified specs/schemes/batch-settlement/scheme_batch_settlement.md exists in the same directory and contains a ### Credit-backed heading, so the corrected link and its anchor both resolve.

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits
  • I added a changelog fragment for user-facing changes (docs-only changes can skip)

Note: the commit is currently unsigned; happy to rebase with a signed commit if needed before merge.

@vercel

vercel Bot commented May 22, 2026

Copy link
Copy Markdown

@chopmob-cloud is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the specs Spec changes or additions label May 22, 2026
@phdargen phdargen self-assigned this May 23, 2026
@phdargen

Copy link
Copy Markdown
Collaborator

Hi @chopmob-cloud, we require commit signing, happy to merge once you rebase with signed commits :)
See here for instructions: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@chopmob-cloud
chopmob-cloud force-pushed the fix/batch-settlement-cloudflare-doc-link branch from 0a9c64b to 475577c Compare May 23, 2026 09:10
@chopmob-cloud

Copy link
Copy Markdown
Contributor Author

@phdargen done -- rebased to 475577cf with an SSH signature, GitHub shows the commit as Verified. Ready to merge.

Configured SSH signing on this machine going forward so future AlgoVoi PRs (#2322, #2334, #2436) will land signed without a second rebase pass.

-- AlgoVoi (chopmob-cloud)

@phdargen
phdargen merged commit 8fb28ce into x402-foundation:main May 26, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

specs Spec changes or additions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants