Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases for prototype (and some linter cleaning) #157

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

admosity
Copy link

@admosity admosity commented May 24, 2016

Added some test cases for using prototype.

  1. Test case for method override (more of an example than spec).
  2. Test case for propagating content when using prototype.

image

Commenting out

expect(elementB2.firstElementChild.nodeName.toLowerCase()).toEqual('span');

passes the test.
image

- added test case for propagating content when using prototype
@admosity admosity changed the title Test cases for prototype Test cases for prototype (and some linter cleaning) May 24, 2016
@admosity
Copy link
Author

Added some test cases for mixins, but can't seem to replicate the issue I'm having. I think in my case the lifecycle triggers from the mixins aren't firing. Will add some test cases with lifecycle hooks.

@admosity
Copy link
Author

image

The lifecycle hooks are not triggering when using a prototype with mixins.

@csuwildcat
Copy link
Member

I have retooled the mixin section of the test spec to cover your cases (I think). If there are any outstanding, I will gladly accept a new commit with any I may have missed :)

@csuwildcat
Copy link
Member

I believe I incorporated the meat of this into the code - if not, let me know and I will address the remaining.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants