Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonarqube Fixes #296

Closed
gorky opened this issue Jun 20, 2022 · 0 comments
Closed

Sonarqube Fixes #296

gorky opened this issue Jun 20, 2022 · 0 comments
Assignees
@joehni
Labels
improvement
Milestone
1.5.x

Comments

@gorky
Copy link
Contributor

gorky commented Jun 20, 2022

I ran this project through Sonarqube and it found a bunch of issues. I have an automated solution for fixing issues. As handling is added for fixing issues, I will submit the patches under this ticket.

If anyone would like access to the Sonarqube server with the scan results, please DM me and I will set you up.

There will be additional updates as the Honor Systems Updater is enhanced to handle more issues and scenarios. As a result, I would suggest keeping this ticket open as there will be additional commits under this topic.
hsujenkins added a commit to j2eeguys/xstream that referenced this issue Jun 20, 2022
@hsujenkins
Honor Systems generated updates
907ceba 
x-stream#296
Automatic updates
https://jenkins.updater.j2eeguys.com/
xstream/src/java/com/thoughtworks/xstream/mapper/SecurityMapper.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream-benchmark/src/java/com/thoughtworks/xstream/tools/benchmark/model/FiveBean.java
    uses deprecated method java/lang/Boolean::<init>(Z)V [java.9]
xstream/src/java/com/thoughtworks/xstream/io/StatefulWriter.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream-benchmark/src/java/com/thoughtworks/xstream/tools/benchmark/targets/ExtendedTarget.java
    uses deprecated method java/lang/Boolean::<init>(Z)V [java.9]
    uses deprecated method java/lang/Integer::<init>(I)V [java.9]
xstream/src/java/com/thoughtworks/xstream/io/json/JettisonStaxWriter.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream-jmh/src/java/com/thoughtworks/xstream/benchmark/jmh/StringConverterBenchmark.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
    Remove this unused import 'com.thoughtworks.xstream.io.xml.Xpp3Driver'. [java:S1128]
xstream-benchmark/src/java/com/thoughtworks/xstream/tools/benchmark/model/Five.java
    uses deprecated method java/lang/Boolean::<init>(Z)V [java.9]
xstream/src/java/com/thoughtworks/xstream/converters/reflection/XStream12FieldKeySorter.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream/src/java/com/thoughtworks/xstream/core/util/PresortedMap.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream/src/java/com/thoughtworks/xstream/core/util/WeakCache.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream/src/java/com/thoughtworks/xstream/converters/reflection/AbstractReflectionConverter.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream/src/java/com/thoughtworks/xstream/io/xml/TraxSource.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream-benchmark/src/java/com/thoughtworks/xstream/tools/benchmark/targets/BasicTarget.java
    uses deprecated method java/lang/Long::<init>(J)V [java.9]
    uses deprecated method java/lang/Byte::<init>(B)V [java.9]
    uses deprecated method java/lang/Double::<init>(D)V [java.9]
    uses deprecated method java/lang/Float::<init>(F)V [java.9]
    uses deprecated method java/lang/Integer::<init>(I)V [java.9]
    uses deprecated method java/lang/Short::<init>(S)V [java.9]
xstream/src/java/com/thoughtworks/xstream/converters/reflection/NativeFieldKeySorter.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream/src/java/com/thoughtworks/xstream/core/util/ThreadSafePropertyEditor.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream/src/java/com/thoughtworks/xstream/core/util/ThreadSafeSimpleDateFormat.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream/src/java/com/thoughtworks/xstream/core/DefaultConverterLookup.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]
xstream-benchmark/src/java/com/thoughtworks/xstream/tools/benchmark/model/SerializableFive.java
    uses deprecated method java/lang/Boolean::<init>(Z)V [java.9]
xstream/src/java/com/thoughtworks/xstream/mapper/AnnotationMapper.java
    Replace the type specification in this constructor call with the diamond operator ("<>"). [squid:S2293]

Also-by: Stephen Davidson <[email protected]>
Signed-off-by: Honor Systems Updater Jenkins <[email protected]>
@gorky gorky mentioned this issue Jun 20, 2022
Closed
@joehni joehni self-assigned this Jul 3, 2022
@joehni joehni added this to the 1.5.x milestone Jul 3, 2022
@joehni joehni closed this as completed in cf61d54 Jul 3, 2022
@gorky gorky mentioned this issue Jul 4, 2022
Open
@clauswollnik clauswollnik mentioned this issue Aug 29, 2022
Open
@ccac001 ccac001 mentioned this issue Sep 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joehni joehni

Labels
improvement
Projects
None yet
Milestone
1.5.x
Development

No branches or pull requests
2 participants
@joehni @gorky