Allow for more frontend settings to be overridden #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulrobertlloyd
force-pushed
the
all-scss-settings
branch
from
3ac2a0d
to
07603b8
Compare
|
Also need to add:
|
|
Replaced by #216. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
govuk-frontendallows a number of values in its SCSS styles to be modified but currently we only allow$govuk-brand-colourand$govuk-font-familyto be modified.This PR adds support for many more, but not all. I’ve excluded those that will be deprecated in v5.0, as well as those relating to form controls as this plugin is not designed to be used on sites that include forms.
Given the number of options, wondering if they should be moved under a top-level option name; perhaps
settings? We can still keepbrandColourandfontFamily, but deprecate them in favour ofsettings.brandColourandsettings.fontFamily.This change was done primarily for my own interests, but worth pointing out that without these changes, it is not currently possible to create a site that uses the same link colours as the MOD.UK Design System or page background colours as used by the Home Office Design System; this change would make that possible.
(See also this upstream fix to
govuk-frontend: alphagov/govuk-frontend#4268)To do