Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openapi spec to 2021-10-05 #195

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imalsogreg
Copy link
Contributor

Hello! I've tried bumping the spec3.json file to the most recent one provided by Stripe.

Following your codegen instructions, there were surprisingly few issues. I did run into a few things however, especially in some apparently new fields that the Stripe API lists as type hash. I've marked these areas with TODO's in the PR. There are about a dozen of them.

I'm posting the PR early, as a draft, in case it's obvious to the maintainers how I should fix this. If you already have your own process for bumping the spec, please feel free to ignore me :) If not, and a bump would be useful, I'd love to help polish this up.

For us, the need for a bump the spec was driven by our use of Stripe subscriptions. The CreateSubscriptionItems schema has changed to accept a Price rather than a Plan, and that's the API we would like to program against.

@arlyon
Copy link
Collaborator

arlyon commented Oct 8, 2021

I believe there are some new APIs that the codegen doesn't handle very gracefully at the moment, as certain structs are ignored / forgotten in the output. I've been meaning to get round to it but haven't had the free time yet. Happy to provide as much help as you need!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants