Skip to content

Formula signature + doc improvements#16

Merged
wylieconlon merged 1 commit intowylieconlon:lens/formula-error-handlingfrom
dej611:lens/formula-signature-help
May 19, 2021
Merged

Formula signature + doc improvements#16
wylieconlon merged 1 commit intowylieconlon:lens/formula-error-handlingfrom
dej611:lens/formula-signature-help

Conversation

@dej611
Copy link
Copy Markdown

@dej611 dej611 commented May 19, 2021

Summary

This PR improves the signature popover while hovering and while typing.
Also the documentation has been increased - probably requires to check the compatibility with #13 that I just saw 😓 -.

  • Adds more info about types/optionality in the function signature
  • Refactor + centralize logic for hover + suggestion and doc in few functions
  • Auto-generate examples based on arguments
  • Fixed few math documentation informations that were wrong
  • Adds and fix some more ES function parameters

I've seen there's a specific component in EUI for markdown, but originally it was using another Markdown component. Which one should be the final one?

Screenshot 2021-05-19 at 16 59 51

Screenshot 2021-05-19 at 17 00 01

Screenshot 2021-05-19 at 17 00 33

Screenshot 2021-05-19 at 17 00 43

Screenshot 2021-05-19 at 17 01 06

Screenshot 2021-05-19 at 17 01 44

Screenshot 2021-05-19 at 17 01 55

Screenshot 2021-05-19 at 17 12 54

for

Screenshot 2021-05-19 at 17 17 44

mul

Screenshot 2021-05-19 at 17 18 00

a

Screenshot 2021-05-19 at 17 18 20

Screenshot 2021-05-19 at 17 18 37

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@wylieconlon wylieconlon merged commit f8cab62 into wylieconlon:lens/formula-error-handling May 19, 2021
@wylieconlon
Copy link
Copy Markdown
Owner

@dej611 Merged this PR

@dej611 dej611 deleted the lens/formula-signature-help branch May 20, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants