Formula documentation

.github/CODEOWNERS

@@ -203,7 +203,6 @@
 /packages/kbn-legacy-logging/ @elastic/kibana-core
 /packages/kbn-crypto/ @elastic/kibana-core
 /packages/kbn-http-tools/ @elastic/kibana-core
-/src/plugins/status_page/ @elastic/kibana-core
 /src/plugins/saved_objects_management/ @elastic/kibana-core
 /src/dev/run_check_published_api_changes.ts @elastic/kibana-core
 /src/plugins/home/public @elastic/kibana-core
@@ -215,7 +214,6 @@
 #CC# /src/plugins/legacy_export/ @elastic/kibana-core
 #CC# /src/plugins/xpack_legacy/ @elastic/kibana-core
 #CC# /src/plugins/saved_objects/ @elastic/kibana-core
-#CC# /src/plugins/status_page/ @elastic/kibana-core
 #CC# /x-pack/plugins/cloud/ @elastic/kibana-core
 #CC# /x-pack/plugins/features/ @elastic/kibana-core
 #CC# /x-pack/plugins/global_search/ @elastic/kibana-core

docs/development/core/server/kibana-plugin-core-server.savedobjectmigrationcontext.converttomultinamespacetypeversion.md

@@ -9,5 +9,5 @@ The version in which this object type is being converted to a multi-namespace ty
 <b>Signature:</b>
 
 ```typescript
-convertToMultiNamespaceTypeVersion?: string;
+readonly convertToMultiNamespaceTypeVersion?: string;
 ```

docs/development/core/server/kibana-plugin-core-server.savedobjectmigrationcontext.log.md

@@ -9,5 +9,5 @@ logger instance to be used by the migration handler
 <b>Signature:</b>
 
 ```typescript
-log: SavedObjectsMigrationLogger;
+readonly log: SavedObjectsMigrationLogger;
 ```

docs/development/core/server/kibana-plugin-core-server.savedobjectmigrationcontext.migrationversion.md

@@ -9,5 +9,5 @@ The migration version that this migration function is defined for
 <b>Signature:</b>
 
 ```typescript
-migrationVersion: string;
+readonly migrationVersion: string;
 ```

src/core/server/saved_objects/migrations/core/document_migrator.ts

@@ -661,13 +661,14 @@ function wrapWithTry(
   migrationFn: SavedObjectMigrationFn,
   log: Logger
 ) {
+  const context = Object.freeze({
+    log: new MigrationLogger(log),
+    migrationVersion: version,
+    convertToMultiNamespaceTypeVersion: type.convertToMultiNamespaceTypeVersion,
+  });
+
   return function tryTransformDoc(doc: SavedObjectUnsanitizedDoc) {
     try {
-      const context = {
-        log: new MigrationLogger(log),
-        migrationVersion: version,
-        convertToMultiNamespaceTypeVersion: type.convertToMultiNamespaceTypeVersion,
-      };
       const result = migrationFn(doc, context);
 
       // A basic sanity check to help migration authors detect basic errors

src/core/server/saved_objects/migrations/types.ts

@@ -56,15 +56,15 @@ export interface SavedObjectMigrationContext {
   /**
    * logger instance to be used by the migration handler
    */
-  log: SavedObjectsMigrationLogger;
+  readonly log: SavedObjectsMigrationLogger;
   /**
    * The migration version that this migration function is defined for
    */
-  migrationVersion: string;
+  readonly migrationVersion: string;
   /**
    * The version in which this object type is being converted to a multi-namespace type
    */
-  convertToMultiNamespaceTypeVersion?: string;
+  readonly convertToMultiNamespaceTypeVersion?: string;
 }
 
 /**

src/core/server/saved_objects/migrationsv2/model.test.ts

@@ -198,6 +198,31 @@ describe('migrations v2 model', () => {
   });
 
   describe('model transitions from', () => {
+    it('transition returns new state', () => {
+      const initState: State = {
+        ...baseState,
+        controlState: 'INIT',
+        currentAlias: '.kibana',
+        versionAlias: '.kibana_7.11.0',
+        versionIndex: '.kibana_7.11.0_001',
+      };
+
+      const res: ResponseType<'INIT'> = Either.right({
+        '.kibana_7.11.0_001': {
+          aliases: {
+            '.kibana': {},
+            '.kibana_7.11.0': {},
+          },
+          mappings: {
+            properties: {},
+          },
+          settings: {},
+        },
+      });
+      const newState = model(initState, res);
+      expect(newState).not.toBe(initState);
+    });
+
     describe('INIT', () => {
       const initState: State = {
         ...baseState,

src/core/server/saved_objects/migrationsv2/model.ts

@@ -9,7 +9,7 @@
 import { gt, valid } from 'semver';
 import * as Either from 'fp-ts/lib/Either';
 import * as Option from 'fp-ts/lib/Option';
-import { cloneDeep } from 'lodash';
+
 import { AliasAction, FetchIndexResponse, isLeftTypeof, RetryableEsClientError } from './actions';
 import { AllActionStates, InitState, State } from './types';
 import { IndexMapping } from '../mappings';
@@ -187,7 +187,7 @@ export const model = (currentState: State, resW: ResponseType<AllActionStates>):
   // control state using:
   // `const res = resW as ResponseType<typeof stateP.controlState>;`
 
-  let stateP: State = cloneDeep(currentState);
+  let stateP: State = currentState;
 
   // Handle retryable_es_client_errors. Other left values need to be handled
   // by the control state specific code below.

src/core/server/saved_objects/migrationsv2/types.ts

@@ -381,7 +381,7 @@ export interface LegacyDeleteState extends LegacyBaseState {
   readonly controlState: 'LEGACY_DELETE';
 }
 
-export type State =
+export type State = Readonly<
   | FatalState
   | InitState
   | DoneState
@@ -411,7 +411,8 @@ export type State =
   | LegacySetWriteBlockState
   | LegacyReindexState
   | LegacyReindexWaitForTaskState
-  | LegacyDeleteState;
+  | LegacyDeleteState
+>;
 
 export type AllControlStates = State['controlState'];
 /**

src/core/server/server.api.md

@@ -2152,9 +2152,9 @@ export interface SavedObjectExportBaseOptions {
 
 // @public
 export interface SavedObjectMigrationContext {
-    convertToMultiNamespaceTypeVersion?: string;
-    log: SavedObjectsMigrationLogger;
-    migrationVersion: string;
+    readonly convertToMultiNamespaceTypeVersion?: string;
+    readonly log: SavedObjectsMigrationLogger;
+    readonly migrationVersion: string;
 }
 
 // @public

src/plugins/dashboard/common/saved_dashboard_references.ts

@@ -5,8 +5,7 @@
  * in compliance with, at your election, the Elastic License 2.0 or the Server
  * Side Public License, v 1.
  */
-
-import semverSatisfies from 'semver/functions/satisfies';
+import Semver from 'semver';
 import { SavedObjectAttributes, SavedObjectReference } from '../../../core/types';
 import { DashboardContainerStateWithType, DashboardPanelState } from './types';
 import { EmbeddablePersistableStateService } from '../../embeddable/common/types';
@@ -24,7 +23,7 @@ export interface SavedObjectAttributesAndReferences {
 }
 
 const isPre730Panel = (panel: Record<string, string>): boolean => {
-  return 'version' in panel ? semverSatisfies(panel.version, '<7.3') : true;
+  return 'version' in panel ? Semver.gt('7.3.0', panel.version) : true;
 };
 
 function dashboardAttributesToState(

x-pack/plugins/enterprise_search/public/applications/app_search/__mocks__/index.ts

@@ -6,3 +6,4 @@
  */
 
 export { mockEngineValues, mockEngineActions } from './engine_logic.mock';
+export { mockRecursivelyFetchEngines, mockSourceEngines } from './recursively_fetch_engines.mock';

x-pack/plugins/enterprise_search/public/applications/app_search/__mocks__/recursively_fetch_engines.mock.ts

@@ -0,0 +1,21 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { EngineDetails } from '../components/engine/types';
+
+export const mockSourceEngines = [
+  { name: 'source-engine-1' },
+  { name: 'source-engine-2' },
+] as EngineDetails[];
+
+export const mockRecursivelyFetchEngines = jest.fn(({ onComplete }) =>
+  onComplete(mockSourceEngines)
+);
+
+jest.mock('../utils/recursively_fetch_engines', () => ({
+  recursivelyFetchEngines: mockRecursivelyFetchEngines,
+}));

x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/meta_engines_table_logic.test.ts

@@ -5,15 +5,16 @@
  * 2.0.
  */
 
-import { LogicMounter, mockFlashMessageHelpers, mockHttpValues } from '../../../../../__mocks__';
-
-import { nextTick } from '@kbn/test/jest';
+import { LogicMounter } from '../../../../../__mocks__';
+import { mockRecursivelyFetchEngines } from '../../../../__mocks__/recursively_fetch_engines.mock';
 
 import { EngineDetails } from '../../../engine/types';
 
 import { MetaEnginesTableLogic } from './meta_engines_table_logic';
 
 describe('MetaEnginesTableLogic', () => {
+  const { mount } = new LogicMounter(MetaEnginesTableLogic);
+
   const DEFAULT_VALUES = {
     expandedRows: {},
     sourceEngines: {},
@@ -44,15 +45,11 @@ describe('MetaEnginesTableLogic', () => {
     metaEngines: [...SOURCE_ENGINES, ...META_ENGINES] as EngineDetails[],
   };
 
-  const { http } = mockHttpValues;
-  const { mount } = new LogicMounter(MetaEnginesTableLogic);
-  const { flashAPIErrors } = mockFlashMessageHelpers;
-
   beforeEach(() => {
     jest.clearAllMocks();
   });
 
-  it('has expected default values', async () => {
+  it('has expected default values', () => {
     mount({}, DEFAULT_PROPS);
     expect(MetaEnginesTableLogic.values).toEqual(DEFAULT_VALUES);
   });
@@ -122,16 +119,6 @@ describe('MetaEnginesTableLogic', () => {
       });
 
       it('calls fetchSourceEngines when it needs to fetch data for the itemId', () => {
-        http.get.mockReturnValueOnce(
-          Promise.resolve({
-            meta: {
-              page: {
-                total_pages: 1,
-              },
-            },
-            results: [{ name: 'source-engine-1' }, { name: 'source-engine-2' }],
-          })
-        );
         mount();
         jest.spyOn(MetaEnginesTableLogic.actions, 'fetchSourceEngines');
 
@@ -142,88 +129,22 @@ describe('MetaEnginesTableLogic', () => {
     });
 
     describe('fetchSourceEngines', () => {
-      it('calls addSourceEngines and displayRow when it has retrieved all pages', async () => {
+      it('calls addSourceEngines and displayRow when it has retrieved all pages', () => {
         mount();
-        http.get.mockReturnValueOnce(
-          Promise.resolve({
-            meta: {
-              page: {
-                total_pages: 1,
-              },
-            },
-            results: [{ name: 'source-engine-1' }, { name: 'source-engine-2' }],
-          })
-        );
         jest.spyOn(MetaEnginesTableLogic.actions, 'displayRow');
         jest.spyOn(MetaEnginesTableLogic.actions, 'addSourceEngines');
 
         MetaEnginesTableLogic.actions.fetchSourceEngines('test-engine-1');
-        await nextTick();
-
-        expect(http.get).toHaveBeenCalledWith(
-          '/api/app_search/engines/test-engine-1/source_engines',
-          {
-            query: {
-              'page[current]': 1,
-              'page[size]': 25,
-            },
-          }
-        );
-        expect(MetaEnginesTableLogic.actions.addSourceEngines).toHaveBeenCalledWith({
-          'test-engine-1': [{ name: 'source-engine-1' }, { name: 'source-engine-2' }],
-        });
-        expect(MetaEnginesTableLogic.actions.displayRow).toHaveBeenCalledWith('test-engine-1');
-      });
-
-      it('display a flash message on error', async () => {
-        http.get.mockReturnValueOnce(Promise.reject());
-        mount();
 
-        MetaEnginesTableLogic.actions.fetchSourceEngines('test-engine-1');
-        await nextTick();
-
-        expect(flashAPIErrors).toHaveBeenCalledTimes(1);
-      });
-
-      it('recursively fetches a number of pages', async () => {
-        mount();
-        jest.spyOn(MetaEnginesTableLogic.actions, 'addSourceEngines');
-
-        // First page
-        http.get.mockReturnValueOnce(
-          Promise.resolve({
-            meta: {
-              page: {
-                total_pages: 2,
-              },
-            },
-            results: [{ name: 'source-engine-1' }],
-          })
-        );
-
-        // Second and final page
-        http.get.mockReturnValueOnce(
-          Promise.resolve({
-            meta: {
-              page: {
-                total_pages: 2,
-              },
-            },
-            results: [{ name: 'source-engine-2' }],
+        expect(mockRecursivelyFetchEngines).toHaveBeenCalledWith(
+          expect.objectContaining({
+            endpoint: '/api/app_search/engines/test-engine-1/source_engines',
           })
         );
-
-        MetaEnginesTableLogic.actions.fetchSourceEngines('test-engine-1');
-        await nextTick();
-
         expect(MetaEnginesTableLogic.actions.addSourceEngines).toHaveBeenCalledWith({
-          'test-engine-1': [
-            // First page
-            { name: 'source-engine-1' },
-            // Second and final page
-            { name: 'source-engine-2' },
-          ],
+          'test-engine-1': [{ name: 'source-engine-1' }, { name: 'source-engine-2' }],
         });
+        expect(MetaEnginesTableLogic.actions.displayRow).toHaveBeenCalledWith('test-engine-1');
       });
     });
   });