Skip to content

fix: adding missing "" to PublicPath and browser.runtime.getUrl. #1597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aklinker1 merged 3 commits into from
Apr 24, 2025
Merged

fix: adding missing "" to PublicPath and browser.runtime.getUrl. #1597

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08fe484
fix: adding missing "" to PublicPath and browser.runtime.getUrl.
nishu-murmu Apr 20, 2025
8b2375b
Merge branch 'main' of github.com:wxt-dev/wxt into public-path-empty-…
nishu-murmu Apr 21, 2025
265dcf5
chore: updating positions.
nishu-murmu Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/wxt/e2e/tests/typescript-project.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,11 @@ describe('TypeScript Project', () => {

declare module "wxt/browser" {
export type PublicPath =
| "/"
| "/options.html"
| "/popup.html"
| "/sandbox.html"
| "/"
| ""
type HtmlPublicPath = Extract<PublicPath, \`\${string}.html\`>
export interface WxtRuntime {
getURL(path: PublicPath): string;
Expand Down
3 changes: 2 additions & 1 deletion packages/wxt/src/core/generate-wxt-dir.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ async function getPathsDeclarationEntry(
isHtmlEntrypoint(entry) ? '.html' : '.js',
),
)
.concat([''])
.concat(await getPublicFiles());

await wxt.hooks.callHook('prepare:publicPaths', wxt, paths);
Expand All @@ -82,6 +81,8 @@ async function getPathsDeclarationEntry(
.map(normalizePath)
.sort()
.map((path) => ` | "/${path}"`)
.concat(` | "/"`)
.concat(` | ""`)
.join('\n');

const template = `// Generated by wxt
Expand Down