Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variation of XCTAssertWorkflowLaunched for use with AnyWorkflow #207

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

nallick
Copy link

@nallick nallick commented Jun 23, 2022

Linked Issue:

Checklist:


If Applicable:

  • Did you test when the first item is skipped?
  • Did you test when the last item is skipped?
  • Did you test when middle items are skipped?
  • Did you test when incorrect data is passed forward?
  • Did you test proceeding backwards?

If Public API Has Changed:

  • Did you deprecate (rather than remove) any old methods/variables/etc? Our philosophy for deprecation.
  • Have you done the best that you can to make sure that the compiler guides people to changing to the new API? (Example: the renamed attribute)
  • If necessary, have you tested the upgrade path for at least N-1 versions? For example, if data persists between v1 and v2 then that upgrade should be tested and as easy as we can make it.

@CLAassistant
Copy link

CLAassistant commented Jun 23, 2022

CLA assistant check
All committers have signed the CLA.

@Tyler-Keith-Thompson
Copy link
Collaborator

Tyler-Keith-Thompson commented Jun 26, 2022

@nallick This looks good. I'll need you to sign the CLA before I can approve merge it.

@nallick
Copy link
Author

nallick commented Jun 27, 2022

@nallick This looks good. I'll need you to sign the CLA before I can approve merge it.

@Tyler-Keith-Thompson There's something weird going on with the CLA tool. I signed it at the same time as I created the PR, but it doesn't show here. When I try to sign it again I get the page with You have agreed to the CLA for wwt/SwiftCurrent and the signing controls at the bottom disabled. Also clicking the "recheck" button doesn't make a difference.

Screen Shot 2022-06-27 at 11 50 26 AM (2)

@Tyler-Keith-Thompson
Copy link
Collaborator

@nallick This looks good. I'll need you to sign the CLA before I can approve merge it.

@Tyler-Keith-Thompson There's something weird going on with the CLA tool. I signed it at the same time as I created the PR, but it doesn't show here. When I try to sign it again I get the page with You have agreed to the CLA for wwt/SwiftCurrent and the signing controls at the bottom disabled. Also clicking the "recheck" button doesn't make a difference.

Screen Shot 2022-06-27 at 11 50 26 AM (2)

I think the problem is you contributed with 2 accounts. One is "nallick" and the other is "nick-nallick-wwt". Both need to sign the agreement for it to work.

@nallick
Copy link
Author

nallick commented Jun 28, 2022

Yeah good catch, that was the problem. I have no idea how that second account got pulled in, but it's fixed now.

@Tyler-Keith-Thompson Tyler-Keith-Thompson merged commit fc8bc23 into wwt:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants