SwiftUI is now out of Beta 🎉 #128

Tyler-Keith-Thompson · 2021-09-13T23:17:28Z

Linked Issue:

Checklist:

Did you sign the Contributor License Agreement?
Is the linter reporting 0 errors?
Did you comply with our styleguide?
Is there adequate test coverage for your new code?
Does the CI pipeline pass?
Did you update the documentation?
Did you update the sample app?
Do we need to increment the minor/major version?
Have you done everything you can to make sure that errors that can occur are compile-time errors, and if they have to be runtime do you have adequate tests and documentation around those runtime errors? For more details.

Co-authored-by: Richard Gist <[email protected]>

… github.io page Co-authored-by: Richard Gist <[email protected]>

…ght desire - TT

… - TT

…flows in UIKit - TT

…ssary - TT

…it makes way more sense there - TT

…ht on the nav link issue - TT

…r - TT

…- TT

…nks once it's nested in the folder structure - TT RAG Co-authored-by: Richard Gist <[email protected]>

Co-authored-by: Richard Gist <[email protected]>

…his is a file URL. That ended up causing all kinds of bizarre behavior that was undesirable, now we are good - TT

Co-authored-by: Richard Gist <[email protected]>

README.md

Co-authored-by: Morgan Zellers <[email protected]>

.github/abstract/Creating Workflows.md

.github/abstract/Type Erasure.md

Co-authored-by: Tyler Thompson <[email protected]>

Sources/SwiftCurrent_SwiftUI/Extensions/SwiftUIFlowPersistenceAdditions.swift

Sources/SwiftCurrent_SwiftUI/Views/ViewControllerWrapper.swift

…t guides - RAG

…lowItem - MZ RAG Co-authored-by: Morgan Zellers <[email protected]>

Co-authored-by: Morgan Zellers <[email protected]>

Co-authored-by: Richard Gist <[email protected]>

Richard-Gist

Approved unless we have interop issues.

…ue, not prod. Fixed tests and set workflowPointer correctly - MZ RAG TT Co-authored-by: Morgan Zellers <[email protected]> Co-authored-by: Tyler Thompson <[email protected]>

…lease-swiftui

… TT RAG Co-authored-by: Morgan Zellers <[email protected]> Co-authored-by: Tyler Thompson <[email protected]>

Tyler-Keith-Thompson and others added 30 commits September 9, 2021 15:36

[skip ci] new-docs - Add video to readme - TT

6530562

[skip ci] new-docs - Use the HTML5 video tag instead - TT

ef52524

Update README.md

fe13f11

[skip ci] new-docs - Get rid of old text - TT

055989e

[ci skip] wip - updated the README

b960bab

Co-authored-by: Richard Gist <[email protected]>

[ci skip] wip - Modified the quickstart

c4d8790

Co-authored-by: Richard Gist <[email protected]>

[ci skip] wip - Call to action is more apparent and guides you to the…

2eef23e

… github.io page Co-authored-by: Richard Gist <[email protected]>

Merge branch 'main' into new-docs

d1dc2d1

[new-docs] - Added a post processor for modifying jazzy docs as we mi…

b22c74b

…ght desire - TT

[new-docs] - Replace readme video with vimeo embed - TT

1047547

[new-docs] - Docs are absolutely beautiful! - TT

979bf71

[new-docs] - Added an abstract for creating workflows - TT

eb860ff

[new-docs] - Added an abstract for how to use SwiftCurrent with UIKit…

e11f3da

… - TT

[new-docs] - Added and udpated abstracts, mostly around Creating Work…

ebae754

…flows in UIKit - TT

[new-docs] - Added an abstract for controlling presentation - TT

d6612d6

[new-docs] - Added an abstract for type erasure - TT

933d38a

[new-docs] - Added an abstract for underlying types - TT

bc206c4

[refactors] - Moved HostedWorkflowItem - TT

2f2b3ea

[refactors] - Got interop with UIKit appropriately skipping when nece…

160a1a4

…ssary - TT

[refactors] - Removed public inits from WorkflowItem - TT

b615fb4

[refactors] - Refactored onFinishPublisher sending nil to the model, …

6600109

…it makes way more sense there - TT

[refactors] - Added a comment pointing to the SO answer that shed lig…

0d101c4

…ht on the nav link issue - TT

[refactors] - Idea was right, location was wrong for onFinishPublishe…

76215b7

…r - TT

[new-docs] - Fixed the abstracts that referred to lowercase workflow …

6317178

…- TT

[new-docs] - Fixed docs post processing so that it does not mangle li…

f04b04f

…nks once it's nested in the folder structure - TT RAG Co-authored-by: Richard Gist <[email protected]>

Update .github/DocsPostProcessor/Package.swift

574fa51

Co-authored-by: Richard Gist <[email protected]>

[new-docs] - the problem was fileURLWithPath, despite the fact that t…

fad9c4f

…his is a file URL. That ended up causing all kinds of bizarre behavior that was undesirable, now we are good - TT

Merge branch 'new-docs' of github.com:wwt/SwiftCurrent into new-docs

cdf8752

[new-docs] - Cleaned up comment - TT

bc26e26

[new-docs] - Added a line about tuples, just for Richard - TT RAG

d6321ed

Co-authored-by: Richard Gist <[email protected]>

morganzellers reviewed Sep 14, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

morganzellers reviewed Sep 14, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

morganzellers reviewed Sep 14, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

Richard-Gist and others added 3 commits September 14, 2021 11:59

[skip ci] release-swiftui - More tweaks to Getting Started - RAG

9f503c2

Apply suggestions from code review

c030a00

Co-authored-by: Morgan Zellers <[email protected]>

Apply suggestions from code review

eea04bc

Co-authored-by: Morgan Zellers <[email protected]>

Tyler-Keith-Thompson commented Sep 14, 2021

View reviewed changes

.github/abstract/Creating Workflows.md Outdated Show resolved Hide resolved

.github/abstract/Type Erasure.md Outdated Show resolved Hide resolved

Apply suggestions from code review

84880b0

Co-authored-by: Tyler Thompson <[email protected]>

Tyler-Keith-Thompson commented Sep 14, 2021

View reviewed changes

Sources/SwiftCurrent_SwiftUI/Extensions/SwiftUIFlowPersistenceAdditions.swift Outdated Show resolved Hide resolved

Tyler-Keith-Thompson commented Sep 14, 2021

View reviewed changes

Sources/SwiftCurrent_SwiftUI/Views/ViewControllerWrapper.swift Show resolved Hide resolved

Richard-Gist and others added 5 commits September 14, 2021 12:53

[skip ci] release-swiftui - Updating links inside of details for UIKi…

82063b5

…t guides - RAG

[skip ci] release-swiftui - Updating links in UIKit guides - RAG

86e1dfc

[release-swiftui] - Removing caseIterable and tweaking docs for Workf…

79559c1

…lowItem - MZ RAG Co-authored-by: Morgan Zellers <[email protected]>

[release-swiftui] - Updating link for See this to learn more - MZ RAG

f83f701

Co-authored-by: Morgan Zellers <[email protected]>

[release-swiftui] - Minor version ramp - mz rag

29bb8f2

Co-authored-by: Richard Gist <[email protected]>

Richard-Gist previously approved these changes Sep 14, 2021

View reviewed changes

morganzellers previously approved these changes Sep 14, 2021

View reviewed changes

Richard-Gist and others added 2 commits September 14, 2021 14:19

[release-swiftui] - Recreation in makeUIViewController was a test iss…

107940b

…ue, not prod. Fixed tests and set workflowPointer correctly - MZ RAG TT Co-authored-by: Morgan Zellers <[email protected]> Co-authored-by: Tyler Thompson <[email protected]>

Merge branch 'release-swiftui' of github.com:wwt/SwiftCurrent into re…

10539fe

…lease-swiftui

Richard-Gist dismissed stale reviews from morganzellers and themself via 10539fe September 14, 2021 20:20

morganzellers previously approved these changes Sep 14, 2021

View reviewed changes

[release-swiftui] - Test to cover when pointer is set in wrapper - MZ…

171f690

… TT RAG Co-authored-by: Morgan Zellers <[email protected]> Co-authored-by: Tyler Thompson <[email protected]>

Richard-Gist dismissed morganzellers’s stale review via 171f690 September 14, 2021 20:28

morganzellers approved these changes Sep 14, 2021

View reviewed changes

Richard-Gist approved these changes Sep 14, 2021

View reviewed changes

Richard-Gist merged commit 90ef67c into main Sep 14, 2021

Richard-Gist deleted the release-swiftui branch September 14, 2021 20:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SwiftUI is now out of Beta 🎉 #128

SwiftUI is now out of Beta 🎉 #128

Tyler-Keith-Thompson commented Sep 13, 2021 •

edited

Loading

Richard-Gist left a comment

SwiftUI is now out of Beta 🎉 #128

SwiftUI is now out of Beta 🎉 #128

Conversation

Tyler-Keith-Thompson commented Sep 13, 2021 • edited Loading

Linked Issue:

Checklist:

Richard-Gist left a comment

Choose a reason for hiding this comment

Tyler-Keith-Thompson commented Sep 13, 2021 •

edited

Loading