-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught PHP Exception it\thecsea\simple_caldav_client\CalDAVException: "Recieved unknown HTTP status" #38
Open
monkey3d
wants to merge
30
commits into
wvrzel:master
Choose a base branch
from
thecsea:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PHP notice in case tags are not present
More PHP notices
Sorry the last fix did solve the displaying of errors but broke some functionality (the approach did not work all the time).
Fix broken code
This fixes a tiny typo that caused FindCalendarHome to fail at its job.
FIX: FindCalendarHome broken due to typo
add a host_proxy option
remove $etag as required param to delete() method. Using yandex calendar I can delete items without $etag.
Update SimpleCalDAVClient.php
Wrong namespace used for DOMDocument
fixed PHPDoc
tedyfd
approved these changes
Nov 24, 2023
FREEPBX17-548 CalDav server http response issue resolved
Fix `Class "it\thecsea\simple_caldav_client\Exception" not found` and inconsistent indentation
Add function getEventByGuid, to search for an event by UID
Add protected definitions to prevent depreciation notices >PHP81, and make preg DAV header search and replace case insensitive as not all caldav servers (Nextcloud is one) serves uppercase DAV.
Small bugfixes and new function implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This message is received when the change method is called.
The http status received is 201.
The change is made, however, but invokes this exception.
By modifying the line
if ( $this->client->GetHttpResultCode() != '204' && $this->client->GetHttpResultCode() != '200')
through
if ( $this->client->GetHttpResultCode() != '204' && $this->client->GetHttpResultCode() != '200' && $this->client->GetHttpResultCode() != '201')
the exception no longer occurs.
cordially thank you