Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty (fix): Fixes #3313 'Implementation is missing' error #3357

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

xerial
Copy link
Member

@xerial xerial commented Jan 29, 2024

No description provided.

@github-actions github-actions bot added the bug label Jan 29, 2024
@xerial xerial enabled auto-merge (squash) January 29, 2024 20:36
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (cba2fb8) 82.57% compared to head (0da6e21) 82.58%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3357      +/-   ##
==========================================
+ Coverage   82.57%   82.58%   +0.01%     
==========================================
  Files         355      355              
  Lines       14896    14899       +3     
  Branches     2446     2436      -10     
==========================================
+ Hits        12300    12305       +5     
+ Misses       2596     2594       -2     
Files Coverage Δ
...rc/main/scala/wvlet/airframe/http/HttpMethod.scala 0.00% <0.00%> (ø)
...vlet/airframe/http/netty/NettyRequestHandler.scala 87.27% <85.71%> (+8.42%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d1ded4...0da6e21. Read the comment docs.

@xerial xerial merged commit 76dd486 into main Jan 29, 2024
17 checks passed
@xerial xerial deleted the fix-netty-missing-method branch January 29, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant