Skip to content

SLT-792: Set enableServiceLinks to false in mariadb statefulsets #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jancis merged 4 commits into from
Sep 29, 2022
Merged

SLT-792: Set enableServiceLinks to false in mariadb statefulsets #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f247c75
SLT-792: Set enableServiceLinks to false in mariadb statefulsets, lik…
Rade333 Sep 27, 2022
e92a4b0
SLT-792: Make the enableServiceLinks value configurable.
Rade333 Sep 27, 2022
8a49f8a
SLT-792: Set mariadb.enableServiceLinks to false in drupal chart.
Rade333 Sep 27, 2022
a459f05
Reverting irrelevant changes to minimise patch size
Jancis Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mariadb/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ The following table lists the configurable parameters of the MariaDB chart and t
| `service.clusterIp.master` | Specific cluster IP for master when service type is cluster IP. Use None for headless service | `nil` |
| `service.clusterIp.slave` | Specific cluster IP for slave when service type is cluster IP. Use None for headless service | `nil` |
| `service.port` | MySQL service port | `3306` |
| `enableServiceLinks` | Set to false to disable service links, which can cause slow pod startup times when there are many services in the current namespace. | `true` |
| `serviceAccount.create` | Specifies whether a ServiceAccount should be created | `false` |
| `serviceAccount.name` | The name of the ServiceAccount to create | Generated using the mariadb.fullname template |
| `schedulerName` | Name of the k8s scheduler (other than default) | `nil` |
Expand Down
1 change: 1 addition & 0 deletions mariadb/templates/master-statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ spec:
component: master
{{- include "mariadb.podLabels" . | nindent 8 }}
spec:
enableServiceLinks: {{ .Values.enableServiceLinks }}
{{- if .Values.schedulerName }}
schedulerName: {{ .Values.schedulerName | quote }}
{{- end }}
Expand Down
1 change: 1 addition & 0 deletions mariadb/templates/slave-statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ spec:
component: slave
{{- include "mariadb.podLabels" . | nindent 8 }}
spec:
enableServiceLinks: {{ .Values.enableServiceLinks }}
{{- if .Values.schedulerName }}
schedulerName: {{ .Values.schedulerName | quote }}
{{- end }}
Expand Down
5 changes: 5 additions & 0 deletions mariadb/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ service:
# master: 30001
# slave: 30002

# The environment variables injected by service links are not used, but can lead to slow boot times when
# there are many services in the current namespace.
# If you experience slow pod startups you probably want to set this to `false`.
enableServiceLinks: true

## Pods Service Account
## ref: https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/
serviceAccount:
Expand Down