Skip to content

fix: fallback to abstract name if no __typename was sent #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ysmolski merged 5 commits into from
Jun 8, 2026
Merged

fix: fallback to abstract name if no __typename was sent #1527

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6dd0049
fix: fallback to abstract name if no __typename was sent
ysmolski Jun 5, 2026
d7055e2
Merge branch 'master' into yury/fix_handle_abstract_object_without_ty…
ysmolski Jun 5, 2026
9fa4c82
add a regression test
ysmolski Jun 8, 2026
39d843d
fix comment
ysmolski Jun 8, 2026
76a8b3e
Merge branch 'master' into yury/fix_handle_abstract_object_without_ty…
ysmolski Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions v2/pkg/engine/resolve/resolvable.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1024,7 +1024,7 @@ func (r *Resolvable) walkArray(arr *Array, value *astjson.Value) bool {
// that resolves an abstract (interface/union) field.
func (r *Resolvable) recordObjectTypeStats(obj *Object, typeName []byte) {
// An array item Object has an empty Path
if len(obj.Path) == 0 || typeName == nil || !obj.isAbstract() {
if len(obj.Path) == 0 || !obj.isAbstract() {
return
}
pathKey := r.currentFieldPath()
Expand All @@ -1033,7 +1033,12 @@ func (r *Resolvable) recordObjectTypeStats(obj *Object, typeName []byte) {
if stats.TypeNames == nil {
stats.TypeNames = make(map[string]int, 1)
}
stats.TypeNames[string(typeName)]++
// Fall back to the declared abstract type name when the subgraph did not return __typename.
name := obj.TypeName
if typeName != nil {
name = string(typeName)
}
stats.TypeNames[name]++
r.typeNameStats[pathKey] = stats
}

Expand Down
Loading