fix: find proper parent when sizedFields parent is a non-list wrapper - #1493
Conversation
Instead of just trying the parent of the fields specifed in the sizedFields and failing on non-list wrapper, find nearest list-typed ancestor to avoid double counting of nested lists.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR fixes actual cost inflation when a non-list wrapper field is annotated with ChangesCost Calculation Fix for Non-List Wrapper Parents
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…-when-sizedfields-parent-is-a
🤖 I have created a release *beep* *boop* --- ## [2.3.0](v2.2.0...v2.3.0) (2026-05-15) ### Features * support dot-path in slicingArguments ([#1485](#1485)) ([2cb8d5e](2cb8d5e)) ### Bug Fixes * find proper parent when sizedFields parent is a non-list wrapper ([#1493](#1493)) ([6b96976](6b96976)), closes [#1492](#1492) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- ## [1.15.0](execution/v1.14.0...execution/v1.15.0) (2026-05-15) ### Features * support dot-path in slicingArguments ([#1485](#1485)) ([2cb8d5e](2cb8d5e)) ### Bug Fixes * find proper parent when sizedFields parent is a non-list wrapper ([#1493](#1493)) ([6b96976](6b96976)), closes [#1492](#1492) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Instead of just trying the parent of the fields specifed in the sizedFields and failing on non-list wrapper, find nearest list-typed ancestor to avoid double counting of nested lists.
Closes #1492