Skip to content

feat: check slicing Arguments passed when requireOneSlicingArgument #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ysmolski merged 9 commits into from
Mar 26, 2026
+718 −26
Merged

feat: check slicing Arguments passed when requireOneSlicingArgument #1456

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ecb21d4
feat: validate operations against listSize:requireOneSlicingArgument
ysmolski Mar 23, 2026
08483b0
add comments
ysmolski Mar 24, 2026
0c7204f
a comment
ysmolski Mar 24, 2026
3faabb5
remove dead code
ysmolski Mar 24, 2026
9721813
remove a dead var
ysmolski Mar 24, 2026
d0acab6
handle multiple errors into the report
ysmolski Mar 24, 2026
286482d
make one implementation less strict
ysmolski Mar 24, 2026
5cd67da
return 400 with an error
ysmolski Mar 25, 2026
1fdc15e
Merge branch 'master' into yury/eng-8842-cost-validate-requireoneslic…
ysmolski Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions execution/engine/execution_engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,12 @@ func (e *ExecutionEngine) Execute(ctx context.Context, operation *graphql.Reques
if report.HasErrors() {
return report
}
if costCalculator != nil {
costCalculator.ValidateSliceArguments(e.config.plannerConfig, execContext.resolveContext.Variables, &report)
if report.HasErrors() {
return report
}
}
operation.ComputeEstimatedCost(costCalculator, e.config.plannerConfig, execContext.resolveContext.Variables)

if execContext.resolveContext.TracingOptions.Enable && !execContext.resolveContext.TracingOptions.ExcludePlannerStats {
Expand Down
Loading
Loading