Skip to content

feat(plan): auto-split root field datasources in NewPlanner #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jensneuse merged 14 commits into from
Mar 5, 2026
Merged

feat(plan): auto-split root field datasources in NewPlanner #1422

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6fa1cdb
chore: move cost tests into separate file (#1418)
ysmolski Mar 4, 2026
049a895
Merge remote-tracking branch 'origin/master' into jensneuse/split-ds-…
jensneuse Mar 4, 2026
087d0a7
feat(plan): auto-split root field datasources in NewPlanner
jensneuse Mar 4, 2026
f9fb69d
Merge branch 'feat/add-caching-support' into jensneuse/split-ds-root-…
jensneuse Mar 4, 2026
30848cc
fix: resolve lint issues (gci formatting, staticcheck)
jensneuse Mar 4, 2026
21d8f74
fix: remove root field caching from field info test
jensneuse Mar 4, 2026
36f278a
refactor(plan): replace datasource pre-split with planner-level root …
jensneuse Mar 4, 2026
fd15005
docs: add inline comments to root field isolation logic
jensneuse Mar 4, 2026
00662a0
test(plan): verify cache configs on isolated root field fetches
jensneuse Mar 4, 2026
b8f684c
fix: correct indentation in graphql_datasource_test.go
jensneuse Mar 4, 2026
b7b6e5d
Merge branch 'feat/add-caching-support' into jensneuse/split-ds-root-…
jensneuse Mar 4, 2026
577cee2
fix: use exact assertions and add doc comment for isolatedRootField
jensneuse Mar 4, 2026
987d94e
test: use full plan assertions and complete cache log comparisons
jensneuse Mar 5, 2026
0483679
fix: add explicit FetchID: 0 to first fetch in planner isolation tests
jensneuse Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions execution/engine/config_factory_federation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,3 +453,4 @@
product: Product!
}`
)

Check failure on line 456 in execution/engine/config_factory_federation_test.go

View workflow job for this annotation

GitHub Actions / Linters (1.25) 

File is not properly formatted (gci)

@coderabbitai coderabbitai Bot Mar 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

CI lint failure (gci) still unresolved for this file.

Please run import/format normalization for this file to satisfy the gci check.

🧰 Tools
🪛 GitHub Check: Linters (1.25)

[failure] 456-456:
File is not properly formatted (gci)

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@execution/engine/config_factory_federation_test.go` at line 456, The test
file's imports are not formatted to satisfy gci; run the import/format
normalization tool (gci or goimports + gofmt -s) on the federation config
factory test file, reorder imports into the standard gci groups, remove any
unused imports, re-run `gofmt`/`goimports` to ensure formatting, and commit the
updated file so the gci linter passes (look for the test function named
TestConfigFactoryFederation to locate the file if needed).

Loading
Loading