-
Notifications
You must be signed in to change notification settings - Fork 158
fix: handle complex types inside inline fragments in gRPC execution plan #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dkorittki
merged 20 commits into
master
from
dominik/eng-9007-router-does-not-resolve-grpc-nested-list-fields-in-response
Mar 5, 2026
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
a897784
fix: create message for field selection sets on inline fragments
dkorittki 1b06df6
chore: add tests to verify the bug
dkorittki f8ab09e
chore: Rename FieldSelectionSet to FragmentFields
dkorittki a59bd4d
fix: don't assume empty fields for inline fragments
dkorittki fcad0fc
fix: add stack for inline fragment refs
dkorittki 72de85f
chore: add schema field to test nested inline fragments
dkorittki 542877b
chore: add test to verify nested inline fragments
dkorittki 2579496
chore: move response descend into plan context + add federation visit…
dkorittki 0851f2f
chore: use stack type for ancestor refs
dkorittki 4e38cf0
chore: add test for another bug
dkorittki 15aa25b
chore: calculate inline fragment ref statelessly
dkorittki 482f4ca
chore: remove test which does not occur in reality
dkorittki 3deb556
chore: gofmt
dkorittki 4f55660
chore: refactor
dkorittki c1f3df2
chore: remove unused fields from test schema
dkorittki 6308734
chore: remove comments
dkorittki 3bd0a59
chore: do pull request suggestions
dkorittki 143e99d
fix: don't leave nested field when never entered it
dkorittki 7274c3f
chore: gofmt
dkorittki 5336170
Merge branch 'master' into dominik/eng-9007-router-does-not-resolve-g…
Noroth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.