Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions v2/pkg/engine/datasource/grpc_datasource/compiler.go
Original file line number Diff line number Diff line change
Expand Up @@ -600,10 +600,10 @@ func (p *RPCCompiler) buildProtoMessageWithContext(inputMessage Message, rpcMess
contextList := p.newEmptyListMessageByName(rootMessage, contextSchemaField.Name)
contextData := p.resolveContextData(context[0], contextRPCField) // TODO handle multiple contexts (resolver requires another resolver)

for _, data := range contextData {
for _, contextElement := range contextData {
val := contextList.NewElement()
valMsg := val.Message()
for fieldName, value := range data {
for fieldName, value := range contextElement {
if err := p.setMessageValue(valMsg, fieldName, value); err != nil {
return nil, err
}
Expand Down Expand Up @@ -676,7 +676,6 @@ func (p *RPCCompiler) resolveContextDataForPath(message protoref.Message, path a
}

return p.resolveDataForPath(msg.Message(), path)

}

// resolveListDataForPath resolves the data for a given path in a list message.
Expand All @@ -696,13 +695,14 @@ func (p *RPCCompiler) resolveListDataForPath(message protoref.List, fd protoref.

for _, val := range values {
if list, isList := val.Interface().(protoref.List); isList {
values := p.resolveListDataForPath(list, fd, path)
values := p.resolveListDataForPath(list, fd, path[1:])
Comment thread
devsergiy marked this conversation as resolved.
result = append(result, values...)
continue
} else {
result = append(result, val)
}
}

result = append(result, values...)
default:
result = append(result, item)
}
Expand Down
32 changes: 20 additions & 12 deletions v2/pkg/engine/datasource/grpc_datasource/execution_plan.go
Original file line number Diff line number Diff line change
Expand Up @@ -907,8 +907,11 @@ func (r *rpcPlanningContext) setResolvedField(walker *astvisitor.Walker, fieldDe
}

for _, contextFieldRef := range contextFields {
contextFieldName := r.definition.FieldDefinitionNameBytes(contextFieldRef)
resolvedPath := fieldPath.WithFieldNameItem(contextFieldName)
mapping := r.resolveFieldMapping(
walker.EnclosingTypeDefinition.NameString(r.definition),
r.definition.FieldDefinitionNameString(contextFieldRef),
)
resolvedPath := fieldPath.WithFieldNameItem(unsafebytes.StringToBytes(mapping))

resolvedField.contextFields = append(resolvedField.contextFields, contextField{
fieldRef: contextFieldRef,
Expand Down Expand Up @@ -1306,6 +1309,19 @@ func (r *rpcPlanningContext) newResolveRPCCall(config *resolveRPCCallConfig) (RP
}
}

fd := r.fieldDefinitionRefForType(r.operation.FieldNameString(resolvedField.fieldRef), resolvedField.parentTypeNode.NameString(r.definition))
if fd == ast.InvalidRef {
return RPCCall{}, fmt.Errorf("unable to build response field: field definition not found for field %s", r.operation.FieldNameString(resolvedField.fieldRef))
}

field, err := r.buildField(resolvedField.parentTypeNode, fd, r.operation.FieldNameString(resolvedField.fieldRef), r.operation.FieldAliasString(resolvedField.fieldRef))
if err != nil {
return RPCCall{}, err
}

field.Name = resolveConfig.FieldMappingData.TargetName
field.Message = responseFieldsMessage

response := RPCMessage{
Name: resolveConfig.Response,
Fields: RPCFields{
Expand All @@ -1315,16 +1331,8 @@ func (r *rpcPlanningContext) newResolveRPCCall(config *resolveRPCCallConfig) (RP
JSONPath: resultFieldName,
Repeated: true,
Message: &RPCMessage{
Name: resolveConfig.RPC + "Result",
Fields: RPCFields{
{
Name: resolveConfig.FieldMappingData.TargetName,
ProtoTypeName: dataType,
JSONPath: r.operation.FieldAliasOrNameString(resolvedField.fieldRef),
Message: responseFieldsMessage,
Optional: !r.definition.TypeIsNonNull(resolvedField.fieldDefinitionTypeRef),
},
},
Name: resolveConfig.RPC + "Result",
Fields: RPCFields{field},
},
},
},
Expand Down
Loading