Skip to content

fix: implement missing subscription updater methods #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkorittki merged 2 commits into from
Oct 6, 2025
Merged

fix: implement missing subscription updater methods #1310

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2b8516
fix: Add missing subscription updater methods
dkorittki Oct 6, 2025
9d03e77
chore: add docs for context
dkorittki Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion v2/pkg/engine/datasource/graphql_datasource/graphql_datasource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8251,7 +8251,6 @@ func (f *FailingSubscriptionClient) SubscribeAsync(ctx *resolve.Context, id uint
}

func (f *FailingSubscriptionClient) Unsubscribe(id uint64) {

}

func (f *FailingSubscriptionClient) Subscribe(ctx *resolve.Context, options GraphQLSubscriptionOptions, updater resolve.SubscriptionUpdater) error {
Expand Down Expand Up @@ -8331,6 +8330,19 @@ func (t *testSubscriptionUpdater) Close(kind resolve.SubscriptionCloseKind) {
t.closed = true
}

// empty method to satisfy the interface, not used in this tests
func (t *testSubscriptionUpdater) CloseSubscription(kind resolve.SubscriptionCloseKind, id resolve.SubscriptionIdentifier) {
}

// empty method to satisfy the interface, not used in this tests
func (t *testSubscriptionUpdater) Subscriptions() map[context.Context]resolve.SubscriptionIdentifier {
return make(map[context.Context]resolve.SubscriptionIdentifier)
}

// empty method to satisfy the interface, not used in this tests
func (t *testSubscriptionUpdater) UpdateSubscription(id resolve.SubscriptionIdentifier, data []byte) {
}

func TestSubscriptionSource_Start(t *testing.T) {
chatServer := httptest.NewServer(subscriptiontesting.ChatGraphQLEndpointHandler())
defer chatServer.Close()
Expand Down