Skip to content

chore: fix the BenchmarkExecutionEngine #1288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devsergiy merged 2 commits into from
Sep 5, 2025
Merged

chore: fix the BenchmarkExecutionEngine #1288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
797fe0b
chore: fix the BenchmarkExecutionEngine
ysmolski Aug 22, 2025
a68ff84
check for errors and use better pattern to skip tests while benchmarking
ysmolski Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions execution/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ test:
.PHONY: test-quick
test-quick:
go test -count=1 ./...
go test -run=^$$ -bench=. -benchtime=1x ./...

# updateTestFixtures will update all! golden fixtures
.PHONY: updateTestFixtures
Expand Down
11 changes: 6 additions & 5 deletions execution/engine/execution_engine_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4668,7 +4668,7 @@ func BenchmarkExecutionEngine(b *testing.B) {
},
},
staticdatasource.Configuration{
Data: `"world"`,
Data: `{"hello": "world"}`,
},
)
require.NoError(b, err)
Expand All @@ -4679,9 +4679,8 @@ func BenchmarkExecutionEngine(b *testing.B) {
})
engineConf.SetFieldConfigurations([]plan.FieldConfiguration{
{
TypeName: "Query",
FieldName: "hello",
DisableDefaultMapping: true,
TypeName: "Query",
FieldName: "hello",
},
})

Expand Down Expand Up @@ -4725,7 +4724,9 @@ func BenchmarkExecutionEngine(b *testing.B) {
for pb.Next() {
bc := pool.Get().(*benchCase)
bc.writer.Reset()
_ = bc.engine.Execute(ctx, &req, bc.writer)
if err := bc.engine.Execute(ctx, &req, bc.writer); err != nil {
b.Fatal(err)
}
pool.Put(bc)
}
})
Expand Down
2 changes: 1 addition & 1 deletion v2/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ test-stability:
.PHONY: test-quick
test-quick:
go test ./...
go test -run=xxxx -bench=. -benchtime=1x ./...
go test -run=^$$ -bench=. -benchtime=1x ./...

clean-testcache:
go clean -testcache
Expand Down
10 changes: 5 additions & 5 deletions v2/pkg/engine/datasource/staticdatasource/static_datasource_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func TestStaticDataSourcePlanning(t *testing.T) {
Fetch: &resolve.SingleFetch{
DataSourceIdentifier: []byte("staticdatasource.Source"),
FetchConfiguration: resolve.FetchConfiguration{
Input: "world",
Input: `{"hello": "world"}`,
DataSource: Source{},
},
},
Expand All @@ -35,6 +35,7 @@ func TestStaticDataSourcePlanning(t *testing.T) {
{
Name: []byte("hello"),
Value: &resolve.String{
Path: []string{"hello"},
Nullable: true,
},
},
Expand All @@ -57,7 +58,7 @@ func TestStaticDataSourcePlanning(t *testing.T) {
},
},
Configuration{
Data: "world",
Data: `{"hello": "world"}`,
},
)
require.NoError(t, err)
Expand All @@ -66,9 +67,8 @@ func TestStaticDataSourcePlanning(t *testing.T) {
},
Fields: []plan.FieldConfiguration{
{
TypeName: "Query",
FieldName: "hello",
DisableDefaultMapping: true,
TypeName: "Query",
FieldName: "hello",
},
},
DisableResolveFieldPositions: true,
Expand Down
Loading