Skip to content

fix: disable minifier for gRPC datasource#1249

Merged
ysmolski merged 1 commit intomasterfrom
yury/eng-7680-disable-minification-for-grpc-datasource-in-order-to-not
Jul 28, 2025
Merged

fix: disable minifier for gRPC datasource#1249
ysmolski merged 1 commit intomasterfrom
yury/eng-7680-disable-minification-for-grpc-datasource-in-order-to-not

Conversation

@ysmolski
Copy link
Copy Markdown
Contributor

@ysmolski ysmolski commented Jul 25, 2025 •
edited by coderabbitai Bot
Loading

Minification can lead to fragments to be created
to reduce the size of operation. We want to reduce the amount of fragments in gRCP Datasource.

Summary by CodeRabbit

  • Documentation
    • Improved and clarified comments throughout the GraphQL datasource planner for better readability and precision.
    • Updated method and function descriptions for enhanced clarity, including details on operation handling and field aliasing.
    • Renamed and documented factory creation functions for gRPC datasources for clearer identification.
  • Refactor
    • Disabled minification of operations for gRPC datasources to ensure proper handling.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 25, 2025 •
edited
Loading

Walkthrough

This change updates comments and documentation for several functions and types in the GraphQL datasource planner, clarifying their behavior and intent. A conditional disables minification of operations for gRPC datasources. Function names and comments related to gRPC factory creation are improved for clarity. No functional changes are introduced except for the minification condition.

Changes

Files / Paths Change Summary
v2/pkg/engine/datasource/graphql_datasource/graphql_datasource.go Updated and expanded comments for multiple functions and types; renamed gRPC factory functions; added explicit minification disabling for gRPC datasources; minor formatting and grammar fixes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 25b23fa and 4da425e.

📒 Files selected for processing (1)
  • v2/pkg/engine/datasource/graphql_datasource/graphql_datasource.go (9 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • v2/pkg/engine/datasource/graphql_datasource/graphql_datasource.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Build and test (go 1.23 / windows-latest)
  • GitHub Check: Build and test (go 1.23 / ubuntu-latest)
  • GitHub Check: Build and test (go 1.23 / ubuntu-latest)
  • GitHub Check: Build and test (go 1.23 / windows-latest)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch yury/eng-7680-disable-minification-for-grpc-datasource-in-order-to-not

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ysmolski ysmolski changed the title fix: disable minifaction for gRPC datasource fix: disable minifier for gRPC datasource Jul 25, 2025
@ysmolski
fix: disable minifier for gRPC datasource
4da425e 
Minification can lead to fragments to be created
to reduce the size of operation. We want to reduce the
amount of fragments in gRCP Datasource.
@ysmolski ysmolski force-pushed the yury/eng-7680-disable-minification-for-grpc-datasource-in-order-to-not branch from 25b23fa to 4da425e Compare July 25, 2025 12:58
@ysmolski
Copy link
Copy Markdown
Contributor Author

ysmolski commented Jul 28, 2025

Merging now, but tests to be done later.

@ysmolski ysmolski merged commit 9a26e5c into master Jul 28, 2025
10 checks passed
@ysmolski ysmolski deleted the yury/eng-7680-disable-minification-for-grpc-datasource-in-order-to-not branch July 28, 2025 07:39
@StarpTech StarpTech mentioned this pull request Jul 25, 2025
Merged
Noroth pushed a commit that referenced this pull request Jul 28, 2025
@StarpTech
chore(master): release 2.0.0-rc.211 (#1248)
ecdd9d7 
🤖 I have created a release *beep* *boop*
---


##
[2.0.0-rc.211](v2.0.0-rc.210...v2.0.0-rc.211)
(2025-07-28)


### Features

* redesign handling for lists in gRPC
([#1246](#1246))
([a06c9db](a06c9db))


### Bug Fixes

* disable minifier for gRPC datasource
([#1249](#1249))
([9a26e5c](9a26e5c))
* test v2 benchmarks on ci
([#1238](#1238))
([d9cfb21](d9cfb21))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
  * Redesigned handling of lists in the gRPC datasource.

* **Bug Fixes**
  * Disabled the minifier for the gRPC datasource.
* Enabled testing of version 2 benchmarks on continuous integration
(CI).

* **Documentation**
  * Added a changelog entry for version 2.0.0-rc.211.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@coderabbitai coderabbitai Bot mentioned this pull request Aug 11, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devsergiy devsergiy devsergiy approved these changes

@Noroth Noroth Awaiting requested review from Noroth Noroth is a code owner

@StarpTech StarpTech Awaiting requested review from StarpTech StarpTech is a code owner

@jensneuse jensneuse Awaiting requested review from jensneuse jensneuse is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ysmolski @devsergiy