Skip to content

fix: test v2 benchmarks on ci #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ysmolski merged 3 commits into from
Jul 25, 2025
Merged

fix: test v2 benchmarks on ci #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2491107
fix: test v2 benchmarks on ci
ysmolski Jul 17, 2025
fb96037
ignore fd_test on windows
ysmolski Jul 17, 2025
0354160
remove noise from tests
ysmolski Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/execution.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ jobs:
with:
go-version: ^${{ matrix.go }}
id: go
- name: CI
- name: Quick tests & benchmarks
working-directory: execution
run: make ci
run: make test-quick
- name: Run tests under race detector
working-directory: execution
if: runner.os != 'Windows' # These are very slow on Windows, skip them
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ jobs:
with:
go-version: ^${{ matrix.go }}
id: go
- name: CI
- name: Quick tests & benchmarks
working-directory: v2
run: make ci
run: make test-quick
- name: Run tests under race detector
working-directory: v2
if: runner.os != 'Windows' # These are very slow on Windows, skip them
Expand Down
10 changes: 0 additions & 10 deletions execution/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ test:
test-quick:
go test -count=1 ./...

.PHONY: test-no-race
test-no-race:
go test -count=1 ./...

# updateTestFixtures will update all! golden fixtures
.PHONY: updateTestFixtures
updateTestFixtures:
Expand All @@ -23,12 +19,6 @@ format:
.PHONY: prepare-merge
prepare-merge: format test

.PHONY: ci
ci: test

.PHONY: ci-quick
ci-full: test-quick

.PHONY: update-deps
update-deps:
go get github.com/wundergraph/graphql-go-tools/v2@upgrade
Expand Down
14 changes: 3 additions & 11 deletions v2/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,11 @@ test-fresh: clean-testcache test
test-stability:
@while $(MAKE) test-fresh; do :; done

# First we test, then we benchmark. Otherwise we would get noisy output from testing logs.
.PHONY: test-quick
test-quick:
go test -count=1 ./...

.PHONY: test
test-no-race:
go test -race ./...
go test ./...
go test -run=xxxx -bench=. -benchtime=1x ./...

clean-testcache:
go clean -testcache
Expand All @@ -30,12 +28,6 @@ format:
.PHONY: prepare-merge
prepare-merge: format test

.PHONY: ci
ci: test

.PHONY: ci-quick
ci-full: test-quick

.PHONY: generate
generate: $(GOPATH)/bin/go-enum $(GOPATH)/bin/mockgen $(GOPATH)/bin/stringer
go generate ./...
Expand Down
2 changes: 1 addition & 1 deletion v2/pkg/engine/datasource/graphql_datasource/graphql_datasource_federation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14684,7 +14684,7 @@ func TestGraphQLDataSourceFederation(t *testing.T) {
},
DisableResolveFieldPositions: true,
Debug: plan.DebugConfiguration{
PrintQueryPlans: true,
PrintQueryPlans: false,
},
}

Expand Down
2 changes: 2 additions & 0 deletions v2/pkg/netpoll/fd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//go:build !windows

package netpoll

import (
Expand Down
Loading