Skip to content

fix: return empty list for nullable lists #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Noroth merged 2 commits into from
Jul 11, 2025
+6 −3
Merged

fix: return empty list for nullable lists #1225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2d14a8
fix: return empty list for nullable lists
Noroth Jul 11, 2025
5b74f30
Merge branch 'master' into ludwig/fix-null-lists
Noroth Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions v2/pkg/engine/datasource/grpc_datasource/grpc_datasource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,13 +184,16 @@ func (d *DataSource) marshalResponseJSON(arena *astjson.Arena, message *RPCMessa

if fd.IsList() {
list := data.Get(fd).List()
// We currently do not yet support to distingish between nullable and non-nullable lists.
// Therefore we always return an empty array for now.
// TODO: Add support for nullable lists.
arr := arena.NewArray()
root.Set(field.AliasOrPath(), arr)

if !list.IsValid() {
root.Set(field.AliasOrPath(), arena.NewNull())
continue
}

arr := arena.NewArray()
root.Set(field.AliasOrPath(), arr)
for i := 0; i < list.Len(); i++ {

switch fd.Kind() {
Expand Down
Loading