Skip to content

feat: use a method to get response body details on demand #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkArchon merged 3 commits into from
Jul 9, 2025
Merged

feat: use a method to get response body details on demand #1218

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b93cc2c
feat: pass in response body
SkArchon Jul 2, 2025
251f89e
fix: update responseinfo body in struct
SkArchon Jul 9, 2025
5fcd7fe
Merge remote-tracking branch 'origin/master' into milinda/use-method-…
SkArchon Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions v2/pkg/engine/resolve/loader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,15 +56,19 @@ type ResponseInfo struct {
Request *http.Request
// ResponseHeaders contains a clone of the headers of the response from the subgraph.
ResponseHeaders http.Header
// ResponseBody contains the response body of the subgraph, it is of type string so that it cannot be manipulated.
ResponseBody string
// This should be private as we do not want user's to access the raw responseBody directly
responseBody *bytes.Buffer
}
Comment thread
SkArchon marked this conversation as resolved.

func (ri *ResponseInfo) GetResponseBody() string {
return ri.responseBody.String()
}

func newResponseInfo(res *result, subgraphError error) *ResponseInfo {
responseInfo := &ResponseInfo{
StatusCode: res.statusCode,
Err: goerrors.Join(res.err, subgraphError),
ResponseBody: res.out.String(),
responseBody: res.out,
}
if res.httpResponseContext != nil {
// We're using the response.Request here, because the body will be nil (since the response was read) and won't
Expand Down
Loading