Skip to content

feat: status code derived fallback errors#1198

Merged
endigma merged 2 commits intomasterfrom
jesse/eng-7409-status-code-derived-errors
Jul 3, 2025
Merged

feat: status code derived fallback errors#1198
endigma merged 2 commits intomasterfrom
jesse/eng-7409-status-code-derived-errors

Conversation

@endigma
Copy link
Copy Markdown
Member

@endigma endigma commented Jul 1, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Improved error reporting when responses cannot be parsed or when data is missing and the HTTP status code indicates an error. Users will now see more informative error messages based on HTTP status codes.
  • Refactor
    • Enhanced internal error handling to support appending multiple errors at once, resulting in clearer and more comprehensive error messages for end-users.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 1, 2025

Walkthrough

The changes update error handling in the subgraph resolution and loading logic. The method for appending subgraph errors now supports multiple errors at once via a variadic signature. Loader error handling is enhanced to better report HTTP status-based errors when JSON parsing fails or data is missing, and error appending calls are unified accordingly.

Changes

File(s) Change Summary
v2/pkg/engine/resolve/context.go Renamed appendSubgraphError to appendSubgraphErrors with a variadic error argument; updated implementation to join multiple errors.
v2/pkg/engine/resolve/loader.go Enhanced error handling in mergeResult for JSON parse failures and non-2XX HTTP status; added renderErrorsStatusFallback; replaced error appending calls to use new variadic method.
v2/pkg/engine/resolve/resolvable.go Replaced error joining with variadic appendSubgraphErrors call; removed unused goerrors import alias.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f778553 and 91b4238.

📒 Files selected for processing (3)
  • v2/pkg/engine/resolve/context.go (1 hunks)
  • v2/pkg/engine/resolve/loader.go (8 hunks)
  • v2/pkg/engine/resolve/resolvable.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
  • v2/pkg/engine/resolve/resolvable.go
  • v2/pkg/engine/resolve/context.go
  • v2/pkg/engine/resolve/loader.go
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: CI Success
  • GitHub Check: Build and test (go 1.23 / windows-latest)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@endigma endigma changed the title feat: status code derived errors feat: status code derived fallback errors Jul 1, 2025
@endigma
Copy link
Copy Markdown
Member Author

endigma commented Jul 1, 2025

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 1, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@endigma endigma force-pushed the jesse/eng-7409-status-code-derived-errors branch from d5401ce to f778553 Compare July 2, 2025 08:03
@endigma endigma marked this pull request as ready for review July 2, 2025 08:03
@endigma endigma force-pushed the jesse/eng-7409-status-code-derived-errors branch from f778553 to 91b4238 Compare July 2, 2025 17:58
Copy link
Copy Markdown
Collaborator

@StarpTech StarpTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@endigma endigma merged commit aa1c7ef into master Jul 3, 2025
10 checks passed
@endigma endigma deleted the jesse/eng-7409-status-code-derived-errors branch July 3, 2025 10:41
endigma pushed a commit that referenced this pull request Jul 3, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.0.0-rc.197](v2.0.0-rc.196...v2.0.0-rc.197)
(2025-07-03)


### Features

* status code derived fallback errors
([#1198](#1198))
([aa1c7ef](aa1c7ef))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **New Features**
  * Introduced status code derived fallback errors.

* **Documentation**
  * Updated the changelog with details for version 2.0.0-rc.197.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants