Skip to content

fix: remove semaphore from ResolveGraphQLSubscription#1043

Merged
alepane21 merged 4 commits intomasterfrom
ale/eng-6285-unable-to-open-more-than-1024-subscription-on-a-single
Jan 23, 2025
Merged

fix: remove semaphore from ResolveGraphQLSubscription#1043
alepane21 merged 4 commits intomasterfrom
ale/eng-6285-unable-to-open-more-than-1024-subscription-on-a-single

Conversation

@alepane21
Copy link
Copy Markdown
Contributor

The semaphore in the sync method was blocking requests after the 1024th from proceeding.

@alepane21 alepane21 changed the title Remove semaphore from ResolveGraphQLSubscription fix: remove semaphore from ResolveGraphQLSubscription Jan 23, 2025
Comment thread v2/pkg/engine/resolve/resolve.go
@alepane21 alepane21 merged commit 76d644e into master Jan 23, 2025
@alepane21 alepane21 deleted the ale/eng-6285-unable-to-open-more-than-1024-subscription-on-a-single branch January 23, 2025 16:31
alepane21 pushed a commit that referenced this pull request Jan 23, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.0.0-rc.144](v2.0.0-rc.143...v2.0.0-rc.144)
(2025-01-23)


### Bug Fixes

* remove semaphore from ResolveGraphQLSubscription
([#1043](#1043))
([76d644e](76d644e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants