fix: delete leftover heartbeat connections#1033
Merged
Conversation
StarpTech
reviewed
Jan 17, 2025
Collaborator
StarpTech
left a comment
There was a problem hiding this comment.
Great catch, looks reasonable to me. Can we add a test for it here or in the router?
Noroth
reviewed
Jan 20, 2025
Noroth
reviewed
Jan 20, 2025
Contributor
Noroth
left a comment
There was a problem hiding this comment.
Looks good. Do you think we should have one more test with 50 subscriptions at once and make sure that all of them are deleted properly?
e.g.:
require.Eventually
Contributor
Author
|
Good point @Noroth , added a test like that |
Noroth
reviewed
Jan 21, 2025
Noroth
approved these changes
Jan 22, 2025
df-wg
pushed a commit
that referenced
this pull request
Jan 23, 2025
🤖 I have created a release *beep* *boop* --- ## [2.0.0-rc.143](v2.0.0-rc.142...v2.0.0-rc.143) (2025-01-23) ### Bug Fixes * delete leftover heartbeat connections ([#1033](#1033)) ([f7492d3](f7492d3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users reported seeing the below sigfault when a connection to a subgraph is interrupted over multipart:
After investigating, the cause seemed to be a number of times where we deleted the subscription trigger but didn't clean up the heartbeat (which is running in a separate thread), causing it to write on a non-existent context. This PR cleans that up